Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ip_range aggregation does not automatically generate a key for each bucket #21045

Closed
jpountz opened this issue Oct 20, 2016 · 3 comments
Closed

ip_range aggregation does not automatically generate a key for each bucket #21045

jpountz opened this issue Oct 20, 2016 · 3 comments
Assignees
@jtibshirani
Labels
:Analytics/Aggregations Aggregations >bug help wanted adoptme

Comments

@jpountz
Copy link
Contributor

jpountz commented Oct 20, 2016

While writing tests for the ip_range aggregation, I noticed that it does not automatically generate a key for each range, while the range aggregation on a numeric field does. Should we make this consistent?
@jpountz jpountz changed the title ip_range aggregation does not outamatically generate a key for each bucket ip_range aggregation does not autamatically generate a key for each bucket Oct 21, 2016
@cbuescher cbuescher mentioned this issue Oct 21, 2016
Merged
@colings86
Copy link
Contributor

@elastic/es-search-aggs

@colings86 colings86 added the help wanted adoptme label Mar 13, 2018
@nikhilbarar
Copy link

Is this issue accepted?

@talevy
Copy link
Contributor

talevy commented Mar 14, 2018

@nikhilbarar the exact details may not have been hashed out, but since this issue was recently tagged with adoptme then yes, it has been accepted as something to look into fixing

@jtibshirani jtibshirani changed the title ip_range aggregation does not autamatically generate a key for each bucket ip_range aggregation does not automatically generate a key for each bucket Apr 26, 2018
@jtibshirani jtibshirani self-assigned this May 17, 2018
@jtibshirani jtibshirani mentioned this issue May 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtibshirani jtibshirani

Labels
:Analytics/Aggregations Aggregations >bug help wanted adoptme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@colings86 @jpountz @talevy @jtibshirani @nikhilbarar