Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentile ranks documentation: text and examples out of sync #30864

Closed
kroepke opened this issue May 25, 2018 · 5 comments
Closed

Percentile ranks documentation: text and examples out of sync #30864

kroepke opened this issue May 25, 2018 · 5 comments
Labels
:Analytics/Aggregations Aggregations >docs General docs changes help wanted adoptme

Comments

@kroepke
Copy link

kroepke commented May 25, 2018

The percentile ranks documentation at https://www.elastic.co/guide/en/elasticsearch/reference/6.0/search-aggregations-metrics-percentile-rank-aggregation.html is talking about percentiles for load times, but the examples do not match the text at all.

Prior to 6.0 the examples were correct, all recent versions are wrong.

@javanna javanna added the :Analytics/Aggregations Aggregations label May 25, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@javanna javanna added >docs General docs changes help wanted adoptme labels May 25, 2018
@javanna
Copy link
Member

javanna commented May 25, 2018

Thanks for reporting this @kroepke . Would you fancy opening a PR to fix this?

@kroepke
Copy link
Author

kroepke commented May 25, 2018

@javanna Should the examples be switched back to pre-6.0 versions?
If so, I can take a look on Monday, sure.

@javanna
Copy link
Member

javanna commented May 28, 2018

I am not sure to be honest, @polyfractal I saw that these changes come from d8414ff . Could you clarify what needs to be done?

@polyfractal
Copy link
Contributor

Yep, this was my fault (fixing the examples so that the tests would pass, but forgetting to update the text). It was subsequently fixed in a community PR: #31652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >docs General docs changes help wanted adoptme
Projects
None yet
Development

No branches or pull requests

4 participants