Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that implement AbstractUpgradeTestCase fail with deprecation warnings #38395

Closed
jkakavas opened this issue Feb 5, 2019 · 2 comments
Closed
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@jkakavas
Copy link
Member

jkakavas commented Feb 5, 2019

AbstractUpgradeTestCase#setupForTest() does a "template exists" request

public void setupForTests() throws Exception {
awaitBusy(() -> {
boolean success = true;
for (String template : templatesToWaitFor()) {
try {
final boolean exists = adminClient()
.performRequest(new Request("HEAD", "_template/" + template))
.getStatusLine().getStatusCode() == 200;
success &= exists;
logger.debug("template [{}] exists [{}]", template, exists);
} catch (IOException e) {
logger.warn("error calling template api", e);
}
}
return success;
});
}

which now started to throw deprecation warnings for types removal

> Warnings: [[types removal] The response format of get index template requests will change in the next major version. Please start using the `include_type_name` parameter set to `false` in the request to move to the new, typeless response format that will be the default in 7.0.]

and makes all tests fail. I assume we can just add setOptions(allowTypeRemovalWarnings()) to the request but seeing this is also a deprecated method, is there any better way?

@jkakavas jkakavas added :Search Foundations/Mapping Index mappings, including merging and defining field types >test-failure Triaged test failures from CI labels Feb 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jkakavas
Copy link
Member Author

jkakavas commented Feb 5, 2019

I took a swing at it in #38396 , in case setOptions(allowTypeRemovalWarnings()) is the way to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

3 participants