Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeIntervalRounding is not optimised for fixed-offset timezones #46771

Closed
DaveCTurner opened this issue Sep 17, 2019 · 2 comments
Closed

TimeIntervalRounding is not optimised for fixed-offset timezones #46771

DaveCTurner opened this issue Sep 17, 2019 · 2 comments
Labels
:Analytics/Aggregations Aggregations >enhancement

Comments

@DaveCTurner
Copy link
Contributor

In #46670 we added a fast path for fixed-offset timezones to TimeUnitRounding, making it play nicely with #30534. However today there is no such fast path through TimeIntervalRounding. Kibana sometimes performs an aggregation using 3h buckets (e.g. when searching a week's worth of data in the Discover tab) and I think we could make such an aggregation quicker in cases where the timezone offset is fixed.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@DaveCTurner
Copy link
Contributor Author

Sorry for the noise, #46670 already addressed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DaveCTurner @elasticmachine