Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to _source documentation #8826

Closed
chuntley opened this issue Dec 8, 2014 · 2 comments
Closed

Update to _source documentation #8826

chuntley opened this issue Dec 8, 2014 · 2 comments
Assignees
Labels
>docs General docs changes feedback_needed

Comments

@chuntley
Copy link

chuntley commented Dec 8, 2014

The current documentation for _source is misleading on the actual ramifications on disabling _source: http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/mapping-source-field.html

The sentence "Though very handy to have around, the source field does incur storage overhead within the index." makes it seem that the only things _source is good for are fetch requests. Without diving deeper into other parts of the documentation you would not realize that disabling source actually disables the ability to reindex data.

I believe a large notification area should be added to this page explaining that disabling _source will also disable the ability to update mappings and reindex data.

@clintongormley
Copy link

@chuntley completely agreed. would you be interested in sending a PR?

@clintongormley clintongormley added >docs General docs changes feedback_needed labels Dec 9, 2014
@clintongormley clintongormley self-assigned this Dec 9, 2014
@clintongormley
Copy link

It sounds like the _source field will no longer be configurable, which removes the need to document the issues with disabling it. Closing in favour of #8142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes feedback_needed
Projects
None yet
Development

No branches or pull requests

2 participants