Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadPool.java looks for a config setting it itself prohibits #9216

Closed
markharwood opened this issue Jan 9, 2015 · 2 comments · Fixed by #18674
Closed

ThreadPool.java looks for a config setting it itself prohibits #9216

markharwood opened this issue Jan 9, 2015 · 2 comments · Fixed by #18674
Assignees
Labels
>bug :Core/Infra/Core Core issues without another label

Comments

@markharwood
Copy link
Contributor

ThreadPool.java creates a background thread to updated an estimated clock time at an interval that is controlled by a configuration setting called estimated_time_interval.
Due to the way the component's settings are parsed this must be declared in configuration with the name threadpool.estimated_time_interval - BUT, earlier in the constructor of this class the call here throws an error if this name is defined in the configuration:

Map<String, Settings> groupSettings = settings.getGroups(THREADPOOL_GROUP);

The reason is that the getGroups call checks that all settings prefixed with threadpool. must be "grouped" i.e. qualified with the name of a threadpool e.g. threadpool.search.size.
Consequently we cannot possibly change the default setting of this interval and the need to do so has emerged as part of controlling search timeouts (see "Setting timer accuracy" section of #9156). A PR for this timeout issue includes a fix that changes the setting name to threadpool.search.estimated_time_interval.

@markharwood markharwood added the :Core/Infra/Core Core issues without another label label Jan 9, 2015
@clintongormley
Copy link

@markharwood is this issue still relevant?

@jasontedor
Copy link
Member

This will be addressed by #18674.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Core Core issues without another label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants