diff --git a/CHANGELOG.md b/CHANGELOG.md index d9c695e9877..2d75c6b1491 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ ## [`main`](https://github.com/elastic/eui/tree/main) +- Updated `testenv` mock for `EuiIcon` to render `aria-label` as text ([#5709](https://github.com/elastic/eui/pull/5709)) + **Breaking changes** - Removed Legacy theme including compiled CSS ([#5688](https://github.com/elastic/eui/pull/5688)) diff --git a/src/components/avatar/__snapshots__/avatar.test.tsx.snap b/src/components/avatar/__snapshots__/avatar.test.tsx.snap index 7a88bf96e53..1559166b8fa 100644 --- a/src/components/avatar/__snapshots__/avatar.test.tsx.snap +++ b/src/components/avatar/__snapshots__/avatar.test.tsx.snap @@ -89,10 +89,11 @@ exports[`EuiAvatar props iconType and iconColor as null is rendered 1`] = ` title="name" > + > + name + `; @@ -105,11 +106,12 @@ exports[`EuiAvatar props iconType and iconColor is rendered 1`] = ` title="name" > + > + name + `; @@ -122,11 +124,12 @@ exports[`EuiAvatar props iconType and iconSize is rendered 1`] = ` title="name" > + > + name + `; @@ -139,11 +142,12 @@ exports[`EuiAvatar props iconType is rendered 1`] = ` title="name" > + > + name + `; diff --git a/src/components/control_bar/__snapshots__/control_bar.test.tsx.snap b/src/components/control_bar/__snapshots__/control_bar.test.tsx.snap index 4d75b94442b..d41b45eb7ed 100644 --- a/src/components/control_bar/__snapshots__/control_bar.test.tsx.snap +++ b/src/components/control_bar/__snapshots__/control_bar.test.tsx.snap @@ -69,11 +69,12 @@ exports[`EuiControlBar is rendered 1`] = ` class="euiControlBar__divider" /> + > + Sample Icon +
@@ -214,11 +215,12 @@ exports[`EuiControlBar props leftOffset is rendered 1`] = ` class="euiControlBar__divider" /> + > + Sample Icon +
@@ -387,11 +389,12 @@ exports[`EuiControlBar props leftOffset is rendered 1`] = ` type="alert" > + > + Sample Icon +
+ > + Sample Icon +
@@ -727,11 +731,12 @@ exports[`EuiControlBar props maxHeight is rendered 1`] = ` type="alert" > + > + Sample Icon +
+ > + Sample Icon +
@@ -1066,11 +1072,12 @@ exports[`EuiControlBar props mobile is rendered 1`] = ` type="alert" > + > + Sample Icon +
+ > + Sample Icon +
+ > + Sample Icon +
@@ -1634,11 +1643,12 @@ exports[`EuiControlBar props rightOffset is rendered 1`] = ` type="alert" > + > + Sample Icon +
+ > + Sample Icon +
@@ -1978,11 +1989,12 @@ exports[`EuiControlBar props showContent is rendered 1`] = ` type="alert" > + > + Sample Icon +
+ > + Sample Icon +
@@ -2322,11 +2335,12 @@ exports[`EuiControlBar props size is rendered 1`] = ` type="alert" > + > + Sample Icon +
+ > + Header actions +
@@ -1121,12 +1122,13 @@ Array [ B
+ > + Header actions +
@@ -1522,12 +1524,13 @@ Array [ A
+ > + Header actions +
@@ -1564,12 +1567,13 @@ Array [ B
+ > + Header actions +
@@ -2268,12 +2272,13 @@ Array [ Column A
+ > + Header actions +
@@ -2312,12 +2317,13 @@ Array [ + > + Header actions + @@ -2691,12 +2697,13 @@ Array [ A + > + Header actions + @@ -2733,12 +2740,13 @@ Array [ B + > + Header actions + diff --git a/src/components/datagrid/body/__snapshots__/data_grid_body.test.tsx.snap b/src/components/datagrid/body/__snapshots__/data_grid_body.test.tsx.snap index 59580c7e998..4b0c6d49d8f 100644 --- a/src/components/datagrid/body/__snapshots__/data_grid_body.test.tsx.snap +++ b/src/components/datagrid/body/__snapshots__/data_grid_body.test.tsx.snap @@ -45,12 +45,13 @@ exports[`EuiDataGridBody renders 1`] = ` columnA + > + Header actions + @@ -87,12 +88,13 @@ exports[`EuiDataGridBody renders 1`] = ` columnB + > + Header actions + diff --git a/src/components/header/__snapshots__/header_logo.test.tsx.snap b/src/components/header/__snapshots__/header_logo.test.tsx.snap index 7e1c1a274f1..feed990cb01 100644 --- a/src/components/header/__snapshots__/header_logo.test.tsx.snap +++ b/src/components/header/__snapshots__/header_logo.test.tsx.snap @@ -8,10 +8,11 @@ exports[`EuiHeaderLogo is rendered 1`] = ` rel="noreferrer" > + > + Elastic + `; @@ -22,10 +23,11 @@ exports[`EuiHeaderLogo renders href 1`] = ` rel="noreferrer" > + > + Elastic + `; @@ -36,10 +38,11 @@ exports[`EuiHeaderLogo renders href with rel 1`] = ` rel="noreferrer" > + > + Elastic + `; @@ -50,9 +53,10 @@ exports[`EuiHeaderLogo renders optional props 1`] = ` style="color:red" > + > + Moby Dick + `; diff --git a/src/components/icon/icon.testenv.tsx b/src/components/icon/icon.testenv.tsx index 186988c8ed0..b2309b75677 100644 --- a/src/components/icon/icon.testenv.tsx +++ b/src/components/icon/icon.testenv.tsx @@ -8,13 +8,18 @@ import React, { ComponentType } from 'react'; -export const EuiIcon = ({ type, ...rest }: any) => ( +export const EuiIcon = ({ type, 'aria-label': ariaLabel, ...rest }: any) => ( + > + { + // render aria-label as text, if it's passed in props + ariaLabel ?? '' + } + ); export const appendIconComponentCache = (_: { diff --git a/src/components/link/__snapshots__/link.test.tsx.snap b/src/components/link/__snapshots__/link.test.tsx.snap index 611526145ca..cf1d21b88ce 100644 --- a/src/components/link/__snapshots__/link.test.tsx.snap +++ b/src/components/link/__snapshots__/link.test.tsx.snap @@ -57,10 +57,11 @@ exports[`EuiLink it is an external link 1`] = ` rel="noreferrer" > + > + External link + `; @@ -146,10 +147,11 @@ exports[`EuiLink supports target 1`] = ` target="_blank" > + > + External link + diff --git a/src/components/markdown_editor/__snapshots__/markdown_editor.test.tsx.snap b/src/components/markdown_editor/__snapshots__/markdown_editor.test.tsx.snap index 2d9e194420a..7402e873fbc 100644 --- a/src/components/markdown_editor/__snapshots__/markdown_editor.test.tsx.snap +++ b/src/components/markdown_editor/__snapshots__/markdown_editor.test.tsx.snap @@ -827,10 +827,11 @@ exports[`EuiMarkdownEditor custom plugins are excluded and popover is rendered 1 > GitHub flavored markdown + > + External link + @@ -1070,11 +1071,12 @@ exports[`EuiMarkdownEditor custom plugins are excluded and popover is rendered 1 type="popout" > + > + External link + GitHub flavored markdown + > + External link + @@ -2520,10 +2523,11 @@ exports[`EuiMarkdownEditor modal with help syntax is rendered 1`] = ` > GitHub flavored markdown + > + External link + @@ -2672,10 +2676,11 @@ exports[`EuiMarkdownEditor modal with help syntax is rendered 1`] = ` > GitHub flavored markdown + > + External link + @@ -2824,10 +2829,11 @@ exports[`EuiMarkdownEditor modal with help syntax is rendered 1`] = ` > GitHub flavored markdown + > + External link + @@ -2964,10 +2970,11 @@ exports[`EuiMarkdownEditor modal with help syntax is rendered 1`] = ` > GitHub flavored markdown + > + External link + @@ -3178,11 +3185,12 @@ exports[`EuiMarkdownEditor modal with help syntax is rendered 1`] = ` type="popout" > + > + External link + + > + my icon aria label + diff --git a/src/components/page/page_header/__snapshots__/page_header.test.tsx.snap b/src/components/page/page_header/__snapshots__/page_header.test.tsx.snap index 3cbfc30c111..8e2f6a3c8db 100644 --- a/src/components/page/page_header/__snapshots__/page_header.test.tsx.snap +++ b/src/components/page/page_header/__snapshots__/page_header.test.tsx.snap @@ -248,11 +248,12 @@ exports[`EuiPageHeader props page content props are passed down is rendered 1`] data-test-subj="test subject string" > + > + aria-label + Page title
+ > + aria-label + Page title
diff --git a/src/components/steps/__snapshots__/step.test.tsx.snap b/src/components/steps/__snapshots__/step.test.tsx.snap index f55b9dc327f..e90b564540f 100644 --- a/src/components/steps/__snapshots__/step.test.tsx.snap +++ b/src/components/steps/__snapshots__/step.test.tsx.snap @@ -89,10 +89,11 @@ exports[`EuiStep props status complete is rendered 1`] = ` class="euiStepNumber euiStepNumber--complete euiStep__circle" > + > + Step 1 is complete +

+ > + Step 1 has errors +

+ > + Step 1 has warnings +

+ > + Step 1 is complete + + > + Step 1 is complete + + > + Step 1 has errors + + > + Step 1 has warnings + + > + Step 1 is complete + `; @@ -89,10 +90,11 @@ exports[`EuiStepNumber props status danger is rendered 1`] = ` class="euiStepNumber euiStepNumber--danger" > + > + Step 1 has errors + `; @@ -152,9 +154,10 @@ exports[`EuiStepNumber props status warning is rendered 1`] = ` class="euiStepNumber euiStepNumber--warning" > + > + Step 1 has warnings + `; diff --git a/src/components/steps/__snapshots__/steps_horizontal.test.tsx.snap b/src/components/steps/__snapshots__/steps_horizontal.test.tsx.snap index 6add58288d7..264367d3c86 100644 --- a/src/components/steps/__snapshots__/steps_horizontal.test.tsx.snap +++ b/src/components/steps/__snapshots__/steps_horizontal.test.tsx.snap @@ -17,10 +17,11 @@ exports[`EuiStepsHorizontal is rendered 1`] = ` class="euiStepNumber euiStepNumber--complete euiStepHorizontal__number" > + > + Step 1 is complete + + > + aria-label + `; diff --git a/src/components/tool_tip/__snapshots__/icon_tip.test.tsx.snap b/src/components/tool_tip/__snapshots__/icon_tip.test.tsx.snap index 231a953b0a5..4e5811beeef 100644 --- a/src/components/tool_tip/__snapshots__/icon_tip.test.tsx.snap +++ b/src/components/tool_tip/__snapshots__/icon_tip.test.tsx.snap @@ -5,10 +5,11 @@ exports[`EuiIconTip is rendered 1`] = ` class="euiToolTipAnchor" > + > + aria-label + `; @@ -17,11 +18,12 @@ exports[`EuiIconTip props color is rendered as the icon color 1`] = ` class="euiToolTipAnchor" > + > + Info + `; @@ -30,10 +32,11 @@ exports[`EuiIconTip props size is rendered as the icon size 1`] = ` class="euiToolTipAnchor" > + > + Info + `; @@ -42,9 +45,10 @@ exports[`EuiIconTip props type is rendered as the icon 1`] = ` class="euiToolTipAnchor" > + > + Info + `; diff --git a/src/components/tour/__snapshots__/tour_step_indicator.test.tsx.snap b/src/components/tour/__snapshots__/tour_step_indicator.test.tsx.snap index b3b6e78b947..9fad8630c4e 100644 --- a/src/components/tour/__snapshots__/tour_step_indicator.test.tsx.snap +++ b/src/components/tour/__snapshots__/tour_step_indicator.test.tsx.snap @@ -7,11 +7,12 @@ exports[`EuiTourStepIndicator can be complete 1`] = ` data-test-subj="test subject string" > + > + complete + `; @@ -22,11 +23,12 @@ exports[`EuiTourStepIndicator can be incomplete 1`] = ` data-test-subj="test subject string" > + > + incomplete + `; @@ -38,10 +40,11 @@ exports[`EuiTourStepIndicator is rendered 1`] = ` > + > + active + `;