Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInMemoryTable] Support a secondary sort option #1322

Closed
chrisronline opened this issue Nov 19, 2018 · 5 comments
Closed

[EuiInMemoryTable] Support a secondary sort option #1322

chrisronline opened this issue Nov 19, 2018 · 5 comments

Comments

@chrisronline
Copy link
Contributor

Currently, you can provide a single sort for EuiInMemoryTable but it'd be nice to specify a secondary sort option to resolve sort collisions from the single sort.

@cchaos cchaos changed the title [Enhancement] Support a secondary sort option for EuiInMemoryTable [EuiInMemoryTable] Support a secondary sort option Sep 19, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

@rashmivkulkarni
Copy link

rashmivkulkarni commented Mar 31, 2021

A test is dependent on this and is failing on jenkins with this error

Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/elasticsearch/indices·js.Monitoring app Elasticsearch indices listing should show indices table with correct rows after sorting by Search Rate Desc (from Chrome X-Pack UI Functional Tests)

Link to failure: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/116371/testReport/junit/Chrome%20X-Pack%20UI%20Functional%20Tests/x-pack_test_functional_apps_monitoring_elasticsearch_indices%C2%B7js/Kibana_Pipeline___general___Monitoring_app_Elasticsearch_indices_listing_should_show_indices_table_with_correct_rows_after_sorting_by_Search_Rate_Desc/
Screen Shot 2021-03-31 at 11 33 22 AM

I also see a comment on the test stating that the functional test will be fixed once this issue is fixed, hence re-opening this issue. ( tested on 7.12)

part of : elastic/kibana#95349

cc @LeeDr @chrisronline @igoristic

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants