Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Cell actions need 2 clicks in Firefox #4235

Closed
kertal opened this issue Nov 6, 2020 · 11 comments
Closed

[EuiDataGrid] Cell actions need 2 clicks in Firefox #4235

kertal opened this issue Nov 6, 2020 · 11 comments

Comments

@kertal
Copy link
Member

kertal commented Nov 6, 2020

If the cell was not already focused, triggering a custom cell action takes 2 clicks in Safari and Firefox. First one focuses the cell, second one triggeres the action. Works as expected in Chrome

image

@kshitij86
Copy link

kshitij86 commented Nov 7, 2020

I want to work on a fix for this. @chandlerprall can I get assigned?

@chandlerprall
Copy link
Contributor

@kshitij86 from https://github.com/elastic/eui/blob/master/CONTRIBUTING.md:

We do not, as a policy, assign issues to community members. If you find an issue that is not assigned, assume that you are welcome to work on it and can submit a pull request. Feel free to leave a comment to mark intent and avoid conflict.

Please go for it!

@kshitij86
Copy link

kshitij86 commented Nov 23, 2020

@kertal does this issue occur only with specific cell actions, like the ones in the GIF or with others as well? I'd also appreciate if you could help me in reproducing this using example code, please?

@kertal
Copy link
Member Author

kertal commented Nov 23, 2020

It‘s a general issue, except for Chrome

@kshitij86
Copy link

@kertal How can I add a custom cell action like that to an example? Do I have to set one of the EuiDataGridCellValueElementProps? Because focusing the cell and selecting the text is possible by double cliking on my version on Firefox, so it must be caused only by adding those.

@kertal
Copy link
Member Author

kertal commented Nov 24, 2020

@kshitij86 there's a good example in our docs, have a look:
https://eui.elastic.co/#/tabular-content/data-grid-styling-and-control#column-cell-actions

@kshitij86
Copy link

@kertal If you take a look at the examples, they are clickable with a single click. Sort of having trouble reproducing this on Linux Mint. Do you think it could be a MacOS specific issue with Firefox?

@kertal
Copy link
Member Author

kertal commented Nov 26, 2020

this is possible, will check if it's also a Windows problem (when I'm allowed to used the windows machine), dear @timroes could you do linux flavored double check in Firefox?

@timroes
Copy link
Contributor

timroes commented Nov 26, 2020

I checked on Linux Firefox 83.0, it does not seem to be an issue there. In the above linked docs page @kertal shared it's triggered by a single click.

While I was trying to record the gif it happened to me once that it seemed not to trigger, but I have the feeling I might just not have hit the button in that case :D


Peek 2020-11-26 16-22

@kshitij86
Copy link

@timroes Yes as the icon doesn't appear unless you hover over the right side, even I thought I had reproduced the issue.

@kertal
Copy link
Member Author

kertal commented Mar 1, 2021

I've checked again, and in the meantime, this has been fixes, so I'm closing it

@kertal kertal closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants