Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] Constrain popover dimensions to its container #6148

Closed
chandlerprall opened this issue Aug 18, 2022 · 2 comments
Closed

[EuiPopover] Constrain popover dimensions to its container #6148

chandlerprall opened this issue Aug 18, 2022 · 2 comments

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Aug 18, 2022

Need to start with an investigation to better understand how the current sizing works (or doesn't), but a popover should limit its sizing to stay within its configured container (window by default).

After poking a little more into the guts of popover_positioning and EuiPopover, this is semi-interesting shenanigans as the positioning service doesn't actually ever set width on anything - it's deriving its calculations purely from the existing width of the panel content, so basically CSS itself is doing a confused psyduck once you set a % width on content popovers.

So, as Chandler mentioned in the above thread, we may need to start modifying EuiPopover to manually set width/height styles where we're currently not... but that may also cause other unexpected shenanigans with popover down the road. Fun times!

Originally posted by @constancecchen in #6146 (comment)

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant