Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] New icons types for Kibana Graph app #6918

Closed
dej611 opened this issue Jul 7, 2023 · 1 comment · Fixed by #6934
Closed

[Icon] New icons types for Kibana Graph app #6918

dej611 opened this issue Jul 7, 2023 · 1 comment · Fixed by #6934

Comments

@dej611
Copy link
Contributor

dej611 commented Jul 7, 2023

Is your feature request related to a problem? Please describe.
The Kibana Graph App is using the old font-awesome 4 package to render its icons.
We're considering the removal of such package and consider the migration of the current icon list to a mix of EUI icons + maki icons set (used by Map).

From the investigation it came out that there are only 2 missing icons which requires to be added from the EUI side: at (@) and key ( 🔑 ).

Edit: also the Google icon is missing

Describe the solution you'd like
Three new icons.

@MichaelMarcialis
Copy link
Contributor

@dej611: I'll put together a PR this week that adds at and key icons to EUI's glyphs. Stay tuned.

For the Google icon you mention, we try to avoid adding logos to our icon library. It is suggested that you use a custom icon instead.

@MichaelMarcialis MichaelMarcialis linked a pull request Jul 11, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants