Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiContextMenu] Missing underline hover on link items in Firefox #7429

Closed
Dosant opened this issue Dec 20, 2023 · 2 comments
Closed

[EuiContextMenu] Missing underline hover on link items in Firefox #7429

Dosant opened this issue Dec 20, 2023 · 2 comments
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible

Comments

@Dosant
Copy link
Contributor

Dosant commented Dec 20, 2023

Describe the bug
EuiContextMenu item hover behavior is different in Firefox. For some reason the underline on hover is missing from links (a[href]) items, but present on buttons (div onclick). In chrome the underline is present for both links and buttons

Impact and severity
Very minor? Just have this the bug in Kibana open for a long time...

Environment and versions

  • EUI version: 91.0.0 and before
  • Kibana version (if applicable): main 8.13 and before
  • Browser: Firefox
  • Operating System: Mac

To Reproduce

You can see it in this demo in Firefox: https://eui.elastic.co/#/navigation/context-menu

When you hover "Handle an onClick" there is an underline;
When you hover "Go to a link" there is no underline

Expected behavior

Underline for both, like in Chrome and Safari

Minimum reproducible sandbox

https://eui.elastic.co/#/navigation/context-menu

@Dosant Dosant added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Dec 20, 2023
@awesomeav
Copy link

hi can i pick it up this bug you can assigned it to me .

@cee-chen
Copy link
Member

cee-chen commented Jan 2, 2024

This should be resolved now in latest EUI - I grabbed it as part of #7373.

Kibana will be fixed once elastic/kibana#173569 merges

@cee-chen cee-chen closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible
Projects
None yet
Development

No branches or pull requests

3 participants