Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The contrast examples on the Theming>Colors page seem to be broken #7500

Closed
ryankeairns opened this issue Feb 2, 2024 · 0 comments · Fixed by #7506
Closed

The contrast examples on the Theming>Colors page seem to be broken #7500

ryankeairns opened this issue Feb 2, 2024 · 0 comments · Fixed by #7506
Assignees
@cee-chen
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@ryankeairns
Copy link
Contributor

It looks like the Contrast tab on the Theming > Colors page needs some attention.

I did some quick checking, and I suspect the changes to ghost could be the culprit… at least, timing wise. The contrast checks look like they were still working in v89, then broke in v90.

Example (page says it would pass, but it doesn't actually per the inspector)

CleanShot 2024-02-01 at 16 05 46@2x
@ryankeairns ryankeairns added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Feb 2, 2024
@cee-chen cee-chen self-assigned this Feb 2, 2024
@cee-chen cee-chen mentioned this issue Feb 2, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cee-chen cee-chen

Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Fix Colors > Contrast docs page cee-chen/eui
2 participants
@ryankeairns @cee-chen