Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulker swallows errors from elasticsearch when the error is specific to the document #1894

Closed
Tracked by #760
blakerouse opened this issue Sep 21, 2022 · 0 comments · Fixed by #1896
Closed
Tracked by #760

Bulker swallows errors from elasticsearch when the error is specific to the document #1894

blakerouse opened this issue Sep 21, 2022 · 0 comments · Fixed by #1896
Assignees
@blakerouse
Labels
Project:FleetScaling Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@blakerouse
Copy link
Contributor

Overview

Inside of the BulkIndexerResponseItem there is an error field that could have possible been set but is ignored in here https://github.com/elastic/fleet-server/blob/main/internal/pkg/bulk/opBulk.go#L77.

What should be done?

Any code path that reads a BulkIndexerResponseItem should check the Error field and ensure that an error has not occurred. If an error has occurred then it should return an error instead of continuing on.

Relates to elastic/elastic-agent#760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blakerouse blakerouse

Labels
Project:FleetScaling Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
1 participant
@blakerouse