From 09b35cffa033f5e7ddb94a7449c23a5c55465993 Mon Sep 17 00:00:00 2001 From: Byron Hulcher Date: Wed, 4 Aug 2021 15:24:52 -0400 Subject: [PATCH] Use different default text for page title while loading --- .../components/crawler/crawler_single_domain.test.tsx | 2 +- .../components/crawler/crawler_single_domain.tsx | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_single_domain.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_single_domain.test.tsx index e08630158163fa..ed8d9628abe833 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_single_domain.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_single_domain.test.tsx @@ -51,6 +51,6 @@ describe('CrawlerSingleDomain', () => { const wrapper = shallow(); - expect(wrapper.prop('pageHeader')).toEqual({ pageTitle: '...' }); + expect(wrapper.prop('pageHeader')).toEqual({ pageTitle: 'Loading...' }); }); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_single_domain.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_single_domain.tsx index 77f7936babd6e7..bdcfa465c8c320 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_single_domain.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_single_domain.tsx @@ -13,6 +13,8 @@ import { useActions, useValues } from 'kea'; import { EuiCode } from '@elastic/eui'; +import { i18n } from '@kbn/i18n'; + import { getEngineBreadcrumbs } from '../engine'; import { AppSearchPageTemplate } from '../layout'; @@ -26,7 +28,11 @@ export const CrawlerSingleDomain: React.FC = () => { const { fetchDomainData } = useActions(CrawlerSingleDomainLogic); - const displayDomainUrl = domain ? domain.url : '...'; + const displayDomainUrl = domain + ? domain.url + : i18n.translate('xpack.enterpriseSearch.appSearch.crawler.singleDomain.loadingTitle', { + defaultMessage: 'Loading...', + }); useEffect(() => { fetchDomainData(domainId);