From 11c5da3d13c39d4d13bba4ecb215cedaceaa27ed Mon Sep 17 00:00:00 2001 From: ppisljar Date: Thu, 13 Jun 2019 09:02:07 -0700 Subject: [PATCH] more cleanup --- src/legacy/ui/public/vis/vis_types/vislib_vis_legend.js | 7 +++---- .../public/visualize/loader/embedded_visualize_handler.ts | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/legacy/ui/public/vis/vis_types/vislib_vis_legend.js b/src/legacy/ui/public/vis/vis_types/vislib_vis_legend.js index c3329cb0307f20e..ce94c3a5f68abba 100644 --- a/src/legacy/ui/public/vis/vis_types/vislib_vis_legend.js +++ b/src/legacy/ui/public/vis/vis_types/vislib_vis_legend.js @@ -22,15 +22,14 @@ import { i18n } from '@kbn/i18n'; import html from './vislib_vis_legend.html'; import { Data } from '../../vislib/lib/data'; import { uiModules } from '../../modules'; -import { VisFiltersProvider } from '../vis_filters'; +import { createFiltersFromEvent } from '../vis_filters'; import { htmlIdGenerator, keyCodes } from '@elastic/eui'; import { getTableAggs } from '../../visualize/loader/pipeline_helpers/utilities'; export const CUSTOM_LEGEND_VIS_TYPES = ['heatmap', 'gauge']; uiModules.get('kibana') - .directive('vislibLegend', function (Private, $timeout) { - const visFilters = Private(VisFiltersProvider); + .directive('vislibLegend', function ($timeout) { return { restrict: 'E', @@ -97,7 +96,7 @@ uiModules.get('kibana') if (CUSTOM_LEGEND_VIS_TYPES.includes($scope.vis.vislibVis.visConfigArgs.type)) { return false; } - const filters = visFilters.filter({ aggConfigs: $scope.tableAggs, data: legendData.values }, { simulate: true }); + const filters = createFiltersFromEvent({ aggConfigs: $scope.tableAggs, data: legendData.values }); return filters.length; }; diff --git a/src/legacy/ui/public/visualize/loader/embedded_visualize_handler.ts b/src/legacy/ui/public/visualize/loader/embedded_visualize_handler.ts index 11ef49f2a0b7b98..431c5ae9be6a1be 100644 --- a/src/legacy/ui/public/visualize/loader/embedded_visualize_handler.ts +++ b/src/legacy/ui/public/visualize/loader/embedded_visualize_handler.ts @@ -33,7 +33,7 @@ import { RenderCompleteHelper } from '../../render_complete'; import { AppState } from '../../state_management/app_state'; import { timefilter } from '../../timefilter'; import { RequestHandlerParams, Vis } from '../../vis'; -// @ts-ignore +// @ts-ignore untyped dependency import { VisFiltersProvider } from '../../vis/vis_filters'; import { PipelineDataLoader } from './pipeline_data_loader'; import { visualizationLoader } from './visualization_loader';