From 209d8135523a1aed5f53991a0be57cf3a5a5e4bb Mon Sep 17 00:00:00 2001
From: Melissa <melissa.alvarez@elastic.co>
Date: Wed, 9 Nov 2022 13:43:25 -0500
Subject: [PATCH] update jest tests

---
 .../scatterplot_matrix_vega_lite_spec.test.ts | 36 +++++++++++--------
 1 file changed, 21 insertions(+), 15 deletions(-)

diff --git a/x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix_vega_lite_spec.test.ts b/x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix_vega_lite_spec.test.ts
index 89ee0add9966ef..1754ab8054592f 100644
--- a/x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix_vega_lite_spec.test.ts
+++ b/x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix_vega_lite_spec.test.ts
@@ -73,7 +73,8 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
   it('should return the default spec for non-outliers without a legend', () => {
     const data = [{ x: 1, y: 1 }];
 
-    const vegaLiteSpec = getScatterplotMatrixVegaLiteSpec(data, ['x', 'y'], euiThemeLight);
+    const vegaLiteSpec = getScatterplotMatrixVegaLiteSpec(data, [], ['x', 'y'], euiThemeLight);
+    const specForegroundLayer = vegaLiteSpec.spec.layer[0];
 
     // A valid Vega Lite spec shouldn't throw an error when compiled.
     expect(() => compile(vegaLiteSpec)).not.toThrow();
@@ -82,17 +83,17 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       column: ['x', 'y'],
       row: ['y', 'x'],
     });
-    expect(vegaLiteSpec.spec.data.values).toEqual(data);
-    expect(vegaLiteSpec.spec.mark).toEqual({
+    expect(specForegroundLayer.data.values).toEqual(data);
+    expect(specForegroundLayer.mark).toEqual({
       opacity: 0.75,
       size: 8,
       type: 'circle',
     });
-    expect(vegaLiteSpec.spec.encoding.color).toEqual({
+    expect(specForegroundLayer.encoding.color).toEqual({
       condition: [{ selection: USER_SELECTION }, { selection: SINGLE_POINT_CLICK }],
       value: COLOR_BLUR,
     });
-    expect(vegaLiteSpec.spec.encoding.tooltip).toEqual([
+    expect(specForegroundLayer.encoding.tooltip).toEqual([
       { field: 'x', type: 'quantitative' },
       { field: 'y', type: 'quantitative' },
     ]);
@@ -101,7 +102,8 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
   it('should return the spec for outliers', () => {
     const data = [{ x: 1, y: 1 }];
 
-    const vegaLiteSpec = getScatterplotMatrixVegaLiteSpec(data, ['x', 'y'], euiThemeLight, 'ml');
+    const vegaLiteSpec = getScatterplotMatrixVegaLiteSpec(data, [], ['x', 'y'], euiThemeLight, 'ml');
+    const specForegroundLayer = vegaLiteSpec.spec.layer[0];
 
     // A valid Vega Lite spec shouldn't throw an error when compiled.
     expect(() => compile(vegaLiteSpec)).not.toThrow();
@@ -110,13 +112,13 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       column: ['x', 'y'],
       row: ['y', 'x'],
     });
-    expect(vegaLiteSpec.spec.data.values).toEqual(data);
-    expect(vegaLiteSpec.spec.mark).toEqual({
+    expect(specForegroundLayer.data.values).toEqual(data);
+    expect(specForegroundLayer.mark).toEqual({
       opacity: 0.75,
       size: 8,
       type: 'circle',
     });
-    expect(vegaLiteSpec.spec.encoding.color).toEqual({
+    expect(specForegroundLayer.encoding.color).toEqual({
       condition: {
         selection: USER_SELECTION,
         field: 'is_outlier',
@@ -127,7 +129,7 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       },
       value: COLOR_BLUR,
     });
-    expect(vegaLiteSpec.spec.encoding.tooltip).toEqual([
+    expect(specForegroundLayer.encoding.tooltip).toEqual([
       { field: 'x', type: 'quantitative' },
       { field: 'y', type: 'quantitative' },
       {
@@ -144,12 +146,14 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
 
     const vegaLiteSpec = getScatterplotMatrixVegaLiteSpec(
       data,
+      [],
       ['x', 'y'],
       euiThemeLight,
       undefined,
       'the-color-field',
       LEGEND_TYPES.NOMINAL
     );
+    const specForegroundLayer = vegaLiteSpec.spec.layer[0];
 
     // A valid Vega Lite spec shouldn't throw an error when compiled.
     expect(() => compile(vegaLiteSpec)).not.toThrow();
@@ -158,13 +162,13 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       column: ['x', 'y'],
       row: ['y', 'x'],
     });
-    expect(vegaLiteSpec.spec.data.values).toEqual(data);
-    expect(vegaLiteSpec.spec.mark).toEqual({
+    expect(specForegroundLayer.data.values).toEqual(data);
+    expect(specForegroundLayer.mark).toEqual({
       opacity: 0.75,
       size: 8,
       type: 'circle',
     });
-    expect(vegaLiteSpec.spec.encoding.color).toEqual({
+    expect(specForegroundLayer.encoding.color).toEqual({
       condition: {
         selection: USER_SELECTION,
         field: 'the-color-field',
@@ -175,7 +179,7 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       },
       value: COLOR_BLUR,
     });
-    expect(vegaLiteSpec.spec.encoding.tooltip).toEqual([
+    expect(specForegroundLayer.encoding.tooltip).toEqual([
       { field: 'the-color-field', type: 'nominal' },
       { field: 'x', type: 'quantitative' },
       { field: 'y', type: 'quantitative' },
@@ -187,12 +191,14 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
 
     const vegaLiteSpec = getScatterplotMatrixVegaLiteSpec(
       data,
+      [],
       ['x.a', 'y[a]'],
       euiThemeLight,
       undefined,
       'the-color-field',
       LEGEND_TYPES.NOMINAL
     );
+    const specForegroundLayer = vegaLiteSpec.spec.layer[0];
 
     // column values should be escaped
     expect(vegaLiteSpec.repeat).toEqual({
@@ -200,6 +206,6 @@ describe('getScatterplotMatrixVegaLiteSpec()', () => {
       row: ['y\\[a\\]', 'x\\.a'],
     });
     // raw data should not be escaped
-    expect(vegaLiteSpec.spec.data.values).toEqual(data);
+    expect(specForegroundLayer.data.values).toEqual(data);
   });
 });