From 2a18b5b03284ebdb65e7741e94ec6565be599921 Mon Sep 17 00:00:00 2001
From: Rashmi Kulkarni <rashmi.kulkarni@elastic.co>
Date: Thu, 23 Jul 2020 14:16:56 -0700
Subject: [PATCH] changes for upgrade assistant functional test to incorporate
 test user (#70071)

* changes for upgrade assistant functional test to incorporate test user

* changes to toggle on/off

* upgrade_assistant role

* upgrade assistant

* more debug statements to check on cloud

* commented the sleeps to check toggle button

* reduced the sleep to 2 seconds to test on cloud

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
---
 .../upgrade_assistant/upgrade_assistant.ts    | 20 +++++++++++++++++--
 x-pack/test/functional/config.js              | 14 +++++++++++++
 2 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts b/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
index 85ad98727cea50..57b8fb23613bea 100644
--- a/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
+++ b/x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
@@ -11,14 +11,22 @@ export default function upgradeAssistantFunctionalTests({
   getPageObjects,
 }: FtrProviderContext) {
   const esArchiver = getService('esArchiver');
-  const PageObjects = getPageObjects(['upgradeAssistant']);
+  const PageObjects = getPageObjects(['upgradeAssistant', 'common']);
+  const security = getService('security');
+  const log = getService('log');
 
   describe('Upgrade Checkup', function () {
     this.tags('includeFirefox');
-    before(async () => await esArchiver.load('empty_kibana'));
+
+    before(async () => {
+      await esArchiver.load('empty_kibana');
+      await security.testUser.setRoles(['global_upgrade_assistant_role']);
+    });
+
     after(async () => {
       await PageObjects.upgradeAssistant.expectTelemetryHasFinish();
       await esArchiver.unload('empty_kibana');
+      await security.testUser.restoreDefaults();
     });
 
     it('allows user to navigate to upgrade checkup', async () => {
@@ -28,9 +36,17 @@ export default function upgradeAssistantFunctionalTests({
 
     it('allows user to toggle deprecation logging', async () => {
       await PageObjects.upgradeAssistant.navigateToPage();
+      log.debug('expect initial state to be ON');
       await PageObjects.upgradeAssistant.expectDeprecationLoggingLabel('On');
+      log.debug('Now toggle to off');
       await PageObjects.upgradeAssistant.toggleDeprecationLogging();
+      await PageObjects.common.sleep(2000);
+      log.debug('expect state to be OFF after toggle');
       await PageObjects.upgradeAssistant.expectDeprecationLoggingLabel('Off');
+      await PageObjects.upgradeAssistant.toggleDeprecationLogging();
+      await PageObjects.common.sleep(2000);
+      log.debug('expect state to be ON after toggle');
+      await PageObjects.upgradeAssistant.expectDeprecationLoggingLabel('On');
     });
 
     it('allows user to open cluster tab', async () => {
diff --git a/x-pack/test/functional/config.js b/x-pack/test/functional/config.js
index 020c5c977bd1b9..08caed0d2f762c 100644
--- a/x-pack/test/functional/config.js
+++ b/x-pack/test/functional/config.js
@@ -284,6 +284,20 @@ export default async function ({ readConfigFile }) {
           ],
         },
 
+        global_upgrade_assistant_role: {
+          elasticsearch: {
+            cluster: ['manage'],
+          },
+          kibana: [
+            {
+              feature: {
+                discover: ['read'],
+              },
+              spaces: ['*'],
+            },
+          ],
+        },
+
         global_ccr_role: {
           elasticsearch: {
             cluster: ['manage', 'manage_ccr'],