From 4df673bbfd391b1b8847804e74dc40fbd84ed73f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mike=20C=C3=B4t=C3=A9?= <mikecote@users.noreply.github.com>
Date: Thu, 28 Nov 2019 08:59:00 -0500
Subject: [PATCH] Fix error returned when creating an alert with ES security
 disabled (#51639)

* Fix error returned when creating an alert with ES security disabled

* Add test to ensure error gets thrown when inner function throws
---
 .../server/lib/alerts_client_factory.test.ts  | 24 +++++++++++++++++++
 .../server/lib/alerts_client_factory.ts       | 12 ++++++----
 2 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/x-pack/legacy/plugins/alerting/server/lib/alerts_client_factory.test.ts b/x-pack/legacy/plugins/alerting/server/lib/alerts_client_factory.test.ts
index 1063e20e4ba3b3..a465aebc8bd86d 100644
--- a/x-pack/legacy/plugins/alerting/server/lib/alerts_client_factory.test.ts
+++ b/x-pack/legacy/plugins/alerting/server/lib/alerts_client_factory.test.ts
@@ -93,6 +93,16 @@ test('createAPIKey() returns { created: false } when security is disabled', asyn
   expect(createAPIKeyResult).toEqual({ created: false });
 });
 
+test('createAPIKey() returns { created: false } when security is enabled but ES security is disabled', async () => {
+  const factory = new AlertsClientFactory(alertsClientFactoryParams);
+  factory.create(KibanaRequest.from(fakeRequest), fakeRequest);
+  const constructorCall = jest.requireMock('../alerts_client').AlertsClient.mock.calls[0][0];
+
+  securityPluginSetup.authc.createAPIKey.mockResolvedValueOnce(null);
+  const createAPIKeyResult = await constructorCall.createAPIKey();
+  expect(createAPIKeyResult).toEqual({ created: false });
+});
+
 test('createAPIKey() returns an API key when security is enabled', async () => {
   const factory = new AlertsClientFactory({
     ...alertsClientFactoryParams,
@@ -105,3 +115,17 @@ test('createAPIKey() returns an API key when security is enabled', async () => {
   const createAPIKeyResult = await constructorCall.createAPIKey();
   expect(createAPIKeyResult).toEqual({ created: true, result: { api_key: '123', id: 'abc' } });
 });
+
+test('createAPIKey() throws when security plugin createAPIKey throws an error', async () => {
+  const factory = new AlertsClientFactory({
+    ...alertsClientFactoryParams,
+    securityPluginSetup: securityPluginSetup as any,
+  });
+  factory.create(KibanaRequest.from(fakeRequest), fakeRequest);
+  const constructorCall = jest.requireMock('../alerts_client').AlertsClient.mock.calls[0][0];
+
+  securityPluginSetup.authc.createAPIKey.mockRejectedValueOnce(new Error('TLS disabled'));
+  await expect(constructorCall.createAPIKey()).rejects.toThrowErrorMatchingInlineSnapshot(
+    `"TLS disabled"`
+  );
+});
diff --git a/x-pack/legacy/plugins/alerting/server/lib/alerts_client_factory.ts b/x-pack/legacy/plugins/alerting/server/lib/alerts_client_factory.ts
index bacb3460421872..b75d681b6586ae 100644
--- a/x-pack/legacy/plugins/alerting/server/lib/alerts_client_factory.ts
+++ b/x-pack/legacy/plugins/alerting/server/lib/alerts_client_factory.ts
@@ -53,12 +53,16 @@ export class AlertsClientFactory {
         if (!securityPluginSetup) {
           return { created: false };
         }
+        const createAPIKeyResult = await securityPluginSetup.authc.createAPIKey(request, {
+          name: `source: alerting, generated uuid: "${uuid.v4()}"`,
+          role_descriptors: {},
+        });
+        if (!createAPIKeyResult) {
+          return { created: false };
+        }
         return {
           created: true,
-          result: (await securityPluginSetup.authc.createAPIKey(request, {
-            name: `source: alerting, generated uuid: "${uuid.v4()}"`,
-            role_descriptors: {},
-          }))!,
+          result: createAPIKeyResult,
         };
       },
     });