fixing flaky tests

elastic · Dec 12, 2018 · b27a735 · b27a735
1 parent f1d6149
commit b27a735
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/test/functional/apps/visualize/_data_table.js b/test/functional/apps/visualize/_data_table.js
@@ -209,7 +209,6 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.visualize.toggleOtherBucket();
         await PageObjects.visualize.toggleMissingBucket();
         await PageObjects.visualize.clickGo();
-        await PageObjects.header.waitUntilLoadingHasFinished();
       });
 
       it('should show correct data', async () => {

diff --git a/test/functional/apps/visualize/_pie_chart.js b/test/functional/apps/visualize/_pie_chart.js
@@ -81,15 +81,15 @@ export default function ({ getService, getPageObjects }) {
         ['160,000', '44'], ['200,000', '40'], ['240,000', '46'], ['280,000', '39'], ['320,000', '40'], ['360,000', '47']
       ];
 
-
+waitUntilLoadingHasFinished
       await PageObjects.visualize.openInspector();
       await PageObjects.visualize.setInspectorTablePageSize(50);
       const data =  await PageObjects.visualize.getInspectorTableData();
       log.debug(data);
       expect(data).to.eql(expectedTableData);
     });
 
-    describe('other bucket', () => {
+    describe.only('other bucket', () => {
       it('should show other and missing bucket', async function () {
         const expectedTableData = [ 'win 8', 'win xp', 'win 7', 'ios', 'Missing', 'Other' ];
 
@@ -118,8 +118,9 @@ export default function ({ getService, getPageObjects }) {
       it('should apply correct filter on other bucket', async () => {
         const expectedTableData = [ 'Missing', 'osx' ];
 
-        await PageObjects.visualize.filterPieSlice('Other');
         await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.visualize.filterPieSlice('Other');
+        await PageObjects.visualize.waitForVisualization();
         const pieData = await PageObjects.visualize.getPieChartLabels();
         log.debug(`pieData.length = ${pieData.length}`);
         expect(pieData).to.eql(expectedTableData);
@@ -131,7 +132,7 @@ export default function ({ getService, getPageObjects }) {
 
         await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.visualize.filterLegend('Other');
-        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.visualize.waitForVisualization();
         const pieData = await PageObjects.visualize.getPieChartLabels();
         log.debug(`pieData.length = ${pieData.length}`);
         expect(pieData).to.eql(expectedTableData);
@@ -154,7 +155,6 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.visualize.toggleMissingBucket();
         log.debug('clickGo');
         await PageObjects.visualize.clickGo();
-        await PageObjects.header.waitUntilLoadingHasFinished();
         const pieData = await PageObjects.visualize.getPieChartLabels();
         log.debug(`pieData.length = ${pieData.length}`);
         expect(pieData).to.eql(expectedTableData);