fixing a11y errors so we can add a11y rules for tslint (#26902) (#26921)

elastic · Dec 10, 2018 · dd8e16a · dd8e16a
1 parent 6232b19
commit dd8e16a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/x-pack/plugins/security/public/views/login/components/basic_login_form/basic_login_form.tsx b/x-pack/plugins/security/public/views/login/components/basic_login_form/basic_login_form.tsx
@@ -57,7 +57,7 @@ class BasicLoginFormUI extends Component<Props, State> {
                 onChange={this.onUsernameChange}
                 disabled={this.state.isLoading}
                 isInvalid={false}
-                aria-required
+                aria-required={true}
                 inputRef={this.setUsernameInputRef}
               />
             </EuiFormRow>
@@ -79,7 +79,7 @@ class BasicLoginFormUI extends Component<Props, State> {
                 onChange={this.onPasswordChange}
                 disabled={this.state.isLoading}
                 isInvalid={false}
-                aria-required
+                aria-required={true}
               />
             </EuiFormRow>
 

diff --git a/x-pack/plugins/security/public/views/management/edit_role/components/edit_role_page.tsx b/x-pack/plugins/security/public/views/management/edit_role/components/edit_role_page.tsx
@@ -96,7 +96,7 @@ class EditRolePageUI extends Component<Props, State> {
               <Fragment>
                 <EuiSpacer size="s" />
                 <EuiText size="s" color="subdued">
-                  <p id="reservedRoleDescription" tabIndex={1}>
+                  <p id="reservedRoleDescription" tabIndex={0}>
                     <FormattedMessage
                       id="xpack.security.management.editRole.modifyingReversedRolesDescription"
                       defaultMessage="Reserved roles are built-in and cannot be removed or modified."