From e175ab3dc7dd6f018c1a352c24766035a5db7545 Mon Sep 17 00:00:00 2001 From: Corey Robertson Date: Wed, 3 Nov 2021 14:46:54 -0400 Subject: [PATCH] unskip stuff --- .../application/hooks/use_dashboard_app_state.test.tsx | 4 ++-- .../dashboard/feature_controls/dashboard_security.ts | 10 +++++----- x-pack/test/functional/config.js | 3 +++ 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.test.tsx b/src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.test.tsx index 5561d1676e41ce4..1064d682d5af2fc 100644 --- a/src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.test.tsx +++ b/src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.test.tsx @@ -208,7 +208,7 @@ describe('Dashboard container lifecycle', () => { // FLAKY: https://github.com/elastic/kibana/issues/116050 // FLAKY: https://github.com/elastic/kibana/issues/105018 -describe.skip('Dashboard initial state', () => { +describe('Dashboard initial state', () => { it('Extracts state from Dashboard Saved Object', async () => { const { renderHookResult, embeddableFactoryResult } = renderDashboardAppStateHook({}); const getResult = () => renderHookResult.result.current; @@ -279,7 +279,7 @@ describe.skip('Dashboard initial state', () => { }); // FLAKY: https://github.com/elastic/kibana/issues/116043 -describe.skip('Dashboard state sync', () => { +describe('Dashboard state sync', () => { let defaultDashboardAppStateHookResult: RenderDashboardStateHookReturn; const getResult = () => defaultDashboardAppStateHookResult.renderHookResult.result.current; diff --git a/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts b/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts index e7aa3e6a54e603e..26fcb2825e07acf 100644 --- a/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts +++ b/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts @@ -51,7 +51,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { await PageObjects.security.forceLogout(); }); - describe('global dashboard all privileges, no embeddable application privileges', () => { + describe.skip('global dashboard all privileges, no embeddable application privileges', () => { before(async () => { await security.role.create('global_dashboard_all_role', { elasticsearch: { @@ -157,7 +157,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { }); }); - describe('global dashboard & embeddable all privileges', () => { + describe.skip('global dashboard & embeddable all privileges', () => { before(async () => { await security.role.create('global_dashboard_visualize_all_role', { elasticsearch: { @@ -254,7 +254,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { }); }); - describe('global dashboard read-only privileges', () => { + describe.skip('global dashboard read-only privileges', () => { before(async () => { await security.role.create('global_dashboard_read_role', { elasticsearch: { @@ -385,7 +385,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { }); }); - describe('global dashboard read-only with url_create privileges', () => { + describe.skip('global dashboard read-only with url_create privileges', () => { before(async () => { await security.role.create('global_dashboard_read_url_create_role', { elasticsearch: { @@ -499,7 +499,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { }); // FLAKY: https://github.com/elastic/kibana/issues/116881 - describe.skip('no dashboard privileges', () => { + describe('no dashboard privileges', () => { before(async () => { await security.role.create('no_dashboard_privileges_role', { elasticsearch: { diff --git a/x-pack/test/functional/config.js b/x-pack/test/functional/config.js index 2abd91fd0433a8b..e57b64095e24242 100644 --- a/x-pack/test/functional/config.js +++ b/x-pack/test/functional/config.js @@ -23,6 +23,8 @@ export default async function ({ readConfigFile }) { return { // list paths to the files that contain your plugins tests testFiles: [ + resolve(__dirname, './apps/dashboard'), + /* resolve(__dirname, './apps/advanced_settings'), resolve(__dirname, './apps/canvas'), resolve(__dirname, './apps/graph'), @@ -60,6 +62,7 @@ export default async function ({ readConfigFile }) { // This license_management file must be last because it is destructive. resolve(__dirname, './apps/license_management'), + */ ], services,