Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String field formatter doesn't apply when highlight was found #103854

Closed
Tracked by #163011
timroes opened this issue Jun 30, 2021 · 3 comments
Closed
Tracked by #163011

String field formatter doesn't apply when highlight was found #103854

timroes opened this issue Jun 30, 2021 · 3 comments
Labels
Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@timroes
Copy link
Contributor

timroes commented Jun 30, 2021

When configuring a string field formatter on a field and then search for a value for it, the highlighting of the fields value completely disables the field formatting for that field, e.g. in the following example I've used the decode base64 formatting (which of course doesn't make the most sense in this example):

screenshot-20210630-115219

If you now search for a value, that has results that are highlighted the formatting will completely be disabled for those fields:

screenshot-20210630-115211

I wonder if we can improve that, at least for the simple field formatter (like uppercase/lowercase) where the actual order and length of the transformed string doesn't change. It's of course harder (i.e. not really possible) to do it on the transforms that actually change the string completely (i.e. base64decode, urlparam and shorten). Though I wonder if for those cases we actually want the highlight to appear and the transform not to apply (the way it's now) or rather the opposite: the highlight simply not to appear but the transform still to apply. Not sure if we've ever discussed that really.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jul 7, 2021
@petrklapka petrklapka added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:AppServicesSv labels Dec 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Aug 9, 2023

We are closing this issue in order to provide better transparency of priorities. This issue won't be prioritized in the near future. We track it in #163011 for long term planning.

@kertal kertal closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Development

No branches or pull requests

4 participants