Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[index patterns] break index patterns out of data plugin into its own plugin #104367

Closed
Tracked by #112832
mattkime opened this issue Jul 6, 2021 · 4 comments
Closed
Tracked by #112832
Assignees
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort technical debt Improvement of the software architecture and operational architecture v7.16.0 v8.0.0

Comments

@mattkime
Copy link
Contributor

mattkime commented Jul 6, 2021

The data plugin is too big. Lets break out the index pattern code into its own plugin.

Parent issue - #84788

@mattkime mattkime added technical debt Improvement of the software architecture and operational architecture Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 v7.15.0 labels Jul 6, 2021
@mattkime mattkime self-assigned this Jul 6, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 6, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jul 6, 2021
@Dosant
Copy link
Contributor

Dosant commented Jul 6, 2021

@mattkime, have you already briefly looked at circular dependencies here and how would we resolve it?
I assume we would want to try making data dependant on index patterns and not another way around?
Also then likely field formatters registry will move together from data into index patterns and maybe even separately, where index patterns depend on field formatters?

@mattkime
Copy link
Contributor Author

mattkime commented Jul 6, 2021

I assume we would want to try making data dependant on index patterns and not another way around?

Yes, although I'm not 100% certain how this would work out. It would be good for the data plugin to expose the index pattern plugin for backwards compatibility but past that I would try to reduce dependencies between the two.

Also then likely field formatters registry will move together from data into index patterns and maybe even separately, where index patterns depend on field formatters?

I'd try to leave field formatters alone, but I need to start on the work to really know.

@exalate-issue-sync exalate-issue-sync bot added loe:large Large Level of Effort and removed loe:medium Medium Level of Effort labels Sep 27, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:large Large Level of Effort labels Sep 27, 2021
@mattkime mattkime added v7.16.0 and removed v7.15.0 labels Oct 9, 2021
@mattkime
Copy link
Contributor Author

mattkime commented Oct 9, 2021

closed by #113497

@mattkime mattkime closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort technical debt Improvement of the software architecture and operational architecture v7.16.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

3 participants