Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] Remove xpack_legacy plugin & /api/settings route #105695

Closed
lukeelmers opened this issue Jul 14, 2021 · 1 comment · Fixed by #114730
Closed

[Breaking] Remove xpack_legacy plugin & /api/settings route #105695

lukeelmers opened this issue Jul 14, 2021 · 1 comment · Fixed by #114730
Assignees
@lukeelmers
Labels
Breaking Change Feature:http impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v8.0.0

Comments

@lukeelmers
Copy link
Member

In #77554 we migrated the legacy /api/settings route to an xpack_legacy plugin in the new platform.

This route exists for Metricbeat to use in the Kibana module, however the route itself is redundant because all of the information it contains can already be retrieved from /api/stats (which Metricbeat also integrates with).

Metricbeat is planning to remove usage of this API in 8.0 in favor of /api/stats, so there is no need for us to keep the old /api/settings route around (or the xpack_legacy plugin it lives inside of).

Currently this API is undocumented, and as far as we are aware is only used by Metricbeat.
@lukeelmers lukeelmers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 Breaking Change labels Jul 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

This was referenced Jul 14, 2021
Closed
Closed
@sixstringcode sixstringcode mentioned this issue Sep 22, 2021
Closed
@lukeelmers lukeelmers added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Feature:http technical debt Improvement of the software architecture and operational architecture labels Oct 12, 2021
@lukeelmers lukeelmers self-assigned this Oct 12, 2021
@lukeelmers lukeelmers mentioned this issue Oct 12, 2021
Merged
This was referenced Feb 23, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukeelmers lukeelmers

Labels
Breaking Change Feature:http impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Breaking] Remove /api/settings & the xpack_legacy plugin. lukeelmers/kibana
2 participants
@lukeelmers @elasticmachine