Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] UI changes for AWS Lambda support #106552

Closed
7 tasks done
AlexanderWert opened this issue Jul 22, 2021 · 6 comments · Fixed by #122775
Closed
7 tasks done

[APM] UI changes for AWS Lambda support #106552

AlexanderWert opened this issue Jul 22, 2021 · 6 comments · Fixed by #122775
Assignees
Labels
good first issue low hanging fruit Team:APM All issues that need APM UI Team support

Comments

@AlexanderWert
Copy link
Member

AlexanderWert commented Jul 22, 2021

With elastic/apm-server#5753 and elastic/apm#352 gathering APM data for AWS Lambda services will be supported.

To have appropriate support in the APM UI, we need a few UI changes:

  • https://github.com/elastic/observability-design/issues/76
  • Based on [APM] Include service.runtime to derive APM service icons  #105917, use the service.runtime.name to derive the primary service icon for AWS Lambda services (instead of the language icon based on agent.name) shown in the service inventory, service overview, service map.
    • Show Lambda icon in all places where only one icon is displayed (service map, service inventory)
    • Show Lambda icon + agent language icon (e.g. Java, Node.js, etc.) + cloud icon (e.g. AWS) in the service overview header, with the following information:
      • Language icon + cloud icon: show same information in the pop-up as it is already the case with those icons
      • Lambda icon:
        • Function Name: from field service.name
        • Function ID: from field service.id
        • Trigger Type: from field faas.trigger.type
  • Hide the metrics tab for AWS Lambda services
  • Hide the instances chart and table on the service overview We actually can use service.node.name as for any other service. So no need to hide the instance views.
  • Add beta badge to cloud details
  • AWS Lambda transactions will have an additional boolean flag indicating a potential cold start of a Lambda. Include a badge on the corresponding transaction row in the waterfall and in the transaction flyout to indicate a cold start. Example:
    image

cc @formgeist

@AlexanderWert AlexanderWert added the Team:APM All issues that need APM UI Team support label Jul 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor

One suggestion would be to move the cold start badge to the end of the description as we do for the other badges e.g. async. Not sure if there was any meaning behind the yellow badge color?

Screenshot 2021-07-29 at 09 20 03

Added a link to the design issue for adding the AWS Lambda icon in the description.

@AlexanderWert
Copy link
Member Author

Not sure if there was any meaning behind the yellow badge color?
Was a meant as a sort of "warning" that the corresponding transaction was a cold start. (But I'm fine with any other color as well)

@formgeist
Copy link
Contributor

Was a meant as a sort of "warning" that the corresponding transaction was a cold start. (But I'm fine with any other color as well)

OK, that makes sense. I think we should keep it as warning.

@formgeist
Copy link
Contributor

#111834 merged so the Lambda icon is now available to use.

@gbamparop
Copy link
Contributor

As discussed with @AlexanderWert and @dannycroft agent icon is still to be displayed in all places where only one icon is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue low hanging fruit Team:APM All issues that need APM UI Team support
Projects
None yet
7 participants