Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] Observability Alerts table should be responsive #108148

Closed
mgiota opened this issue Aug 11, 2021 · 6 comments
Closed

[RAC] Observability Alerts table should be responsive #108148

mgiota opened this issue Aug 11, 2021 · 6 comments
Assignees
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v8.0.0

Comments

@mgiota
Copy link
Contributor

mgiota commented Aug 11, 2021

📝 Summary

The Observability alerts table at the moment is not responsive in smaller screen resolutions. The reason field gets cut off. If user adds more columns in the table, more columns would be cut off as well. The existing horizontal scrollbar gets cut off and doesn't allow the rest columns to be shown.

Screenshot 2021-08-11 at 10 15 18

✔️ Acceptance criteria

As a short term solution we should make sure the horizontal scrollbar works and all columns are visible similar to Security solution.

Screenshot 2021-08-11 at 10 22 10

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 11, 2021
@mgiota mgiota added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 11, 2021
@mgiota mgiota added v7.15.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed Theme: rac label obsolete labels Aug 11, 2021
@jasonrhodes
Copy link
Member

I'd be surprised if EUI Data Grid doesn't have a simple way to make itself responsive. CC: @elastic/eui-design

@cchaos
Copy link
Contributor

cchaos commented Aug 11, 2021

It does not 😉 . EuiDataGrid is meant to me an excel-like experience so it does overflow it's container and adds scrolling. Only the EuiBasicTable has built-in mobile views.

@weltenwort
Copy link
Member

weltenwort commented Aug 11, 2021

Maybe I'm misinterpreting it, but I think the term "responsive" is not quite meant as strictly here. This is mostly about the grid reacting to size changes of its container, even if only by adding overflow scrollbars instead of columns just rendering off-screen.

I think that is something the data grid is capable of according to the EUI docs, but something in the t-grid or the its embedded breaks that capability.

@mgiota
Copy link
Contributor Author

mgiota commented Aug 16, 2021

@weltenwort I think you got it right. This issue is about making sure we have at least a horizontal scrollbar that works well and reacts to size change of its container. At the moment while I keep resizing the browser, it doesn't do what it is supposed to do, whereas if I refresh the browser it works well and all columns get rendered within the scrollable area.

@afgomez afgomez self-assigned this Aug 19, 2021
@afgomez
Copy link
Contributor

afgomez commented Aug 19, 2021

@mgiota @jasonrhodes this seems to be fixed on device.

Screen.Recording.2021-08-19.at.16.51.59.mov

Resizing also seems to work correctly

Screen.Recording.2021-08-19.at.16.54.49.mov

The only issue I see is that the Updated X time ago overlaps, but that will be fixed once we tackle the last element in #107629

@afgomez afgomez closed this as completed Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

6 participants