Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Alerting authorization should always exempt alerts consumer #108206

Closed
ymao1 opened this issue Aug 11, 2021 · 1 comment · Fixed by #108220
Closed

[Alerting] Alerting authorization should always exempt alerts consumer #108206

ymao1 opened this issue Aug 11, 2021 · 1 comment · Fixed by #108220
Assignees
@ymao1
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Aug 11, 2021

As part of the alerting authorization refactor, we changed the hard-coded exemption for alerts consumer to allow users of the client to pass in their own exemptions. This is what the rules client does. Seems like this generification wasn't necessary and instead we should always be exempting the alerts consumer for all users of the alerting authorization client.
@ymao1 ymao1 added Feature:Alerting Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 added the bug Fixes for quality problems that affect the customer experience label Aug 11, 2021
@jasonrhodes jasonrhodes mentioned this issue Aug 11, 2021
Closed
52 tasks
@ymao1 ymao1 mentioned this issue Aug 11, 2021
Merged
1 task
@ymao1 ymao1 self-assigned this Aug 11, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymao1 ymao1

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Alerting] Alerting authorization should always exempt alerts consumer ymao1/kibana
3 participants
@kobelb @ymao1 @elasticmachine