Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert Table loading state for change and switching pagination #108432

Closed
mdefazio opened this issue Aug 12, 2021 · 6 comments · Fixed by #110504
Closed

Alert Table loading state for change and switching pagination #108432

mdefazio opened this issue Aug 12, 2021 · 6 comments · Fixed by #110504
Assignees
Labels
Feature:RAC label obsolete Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete

Comments

@mdefazio
Copy link
Contributor

mdefazio commented Aug 12, 2021

When switching the pagination count or changing pages, the loading indicator appears below the current list of rows.

Screen Recording 2021-08-12 at 02 26 55 PM

The expected behavior should be:
When switching pages, height of the table remains the same, loading indicator overlays (or replaces) rows. New rows get loaded in and loading indicator is removed

When adding in rows (switching from 25 -> 100 per page) this ideally be similar to scrolling down a long list where the new rows would be added as I scroll down.

Example:
If I am at the top of the table and choose to change from 25 to 100 per page, the height of the data grid would then change but the content below the first visible 25 rows would be blank until they load. Similarly if I have 100 rows per page set, but my viewport can only see 25, as I scroll down the page, the additional rows would be loaded in a similar fashion. These two experiences should be similar.

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 12, 2021
@mdefazio mdefazio added Feature:RAC label obsolete Theme: rac label obsolete and removed needs-team Issues missing a team label labels Aug 12, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 12, 2021
@mdefazio mdefazio added the Team:Threat Hunting Security Solution Threat Hunting Team label Aug 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 19, 2021
@mdefazio mdefazio removed the Team:Threat Hunting Security Solution Threat Hunting Team label Aug 19, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 19, 2021
@XavierM
Copy link
Contributor

XavierM commented Aug 19, 2021

FYI -> @asnehalb @paulewing
After discussing it internally, we are seeing two problems here:

  1. When we are switching the row per page that we are loosing the scrolling position on the table. The reason for this behavior is because we are only loading the first 25 alerts and when you change the row per page, we will re-load for example the 50 alerts and go back to first page. At this time to change this behavior, it will be really difficult for us. We will need to discuss how we can improve it technically and then see the implication of this new solution between the one that we have.
  2. About the loading replacing the pagination, I do agree, it does not feel/look good. At the moment, we are not using the EuiDatagrid pagination but we have a POC to use it [RAC] EuiDataGrid pagination #109269. so hopefully that will improve the UX.

@katrin-freihofner
Copy link
Contributor

@mdefazio this seems to be done from the design side, can we close it?

@mdefazio
Copy link
Contributor Author

@katrin-freihofner , I don't think there's additional design work at the moment. It seems like the POC solves this issue. However, is there a separate issue to track this from the engineering side so we know when this is fixed?

@katrin-freihofner katrin-freihofner added the Team:Threat Hunting Security Solution Threat Hunting Team label Aug 25, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 25, 2021
@katrin-freihofner
Copy link
Contributor

I will add the labels so engineering can pick it up.

@afgomez
Copy link
Contributor

afgomez commented Sep 1, 2021

This was fixed in #109269

@afgomez afgomez closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:RAC label obsolete Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete
Projects
None yet
5 participants