Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument Fleet's setup APIs with APM spans #109072

Closed
joshdover opened this issue Aug 18, 2021 · 2 comments · Fixed by #131223
Closed

Instrument Fleet's setup APIs with APM spans #109072

joshdover opened this issue Aug 18, 2021 · 2 comments · Fixed by #131223
Assignees
Labels
performance Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@joshdover
Copy link
Contributor

joshdover commented Aug 18, 2021

Related to https://github.com/elastic/dev/issues/1443

We'd like to keep an eye on the performance of Fleet's setup sequence to ensure that we do not degrade the performance of this over time and to help spot any performance optimizations that may be available today. The performance of this process is important to ensure a smooth onboarding process for new users.

Similar to #109055, we'd like to be able to monitor how the performance of this API changes over time and to alert us if any major performance regressions are introduced. Kibana's CI already enables and collects APM data during executions of the functional test suite, and each HTTP route is already instrumented as a transaction. We should be able to leverage the existing data to establish a baseline. Adding custom APM spans would allows us to better identify which parts of the setup process are taking the most time.

Cloud's integration testing should also be able to leverage APM to measure this over time and ensure that Fleet's setup time is also staying performant in that environment.

@joshdover joshdover added performance Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover joshdover changed the title Instrument Fleet's setup APIs with an APM transaction Instrument Fleet's setup APIs with APM spans Aug 18, 2021
@lizozom
Copy link
Contributor

lizozom commented Apr 18, 2022

Is this a subset of #129050?

As for the infrastructure, if we want to do this in CI, this sounds like it could be a follow up phase to https://github.com/elastic/kibana-team/issues/501?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants