Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of 401 responses #110264

Closed
legrego opened this issue Aug 26, 2021 · 3 comments
Closed

Improve handling of 401 responses #110264

legrego opened this issue Aug 26, 2021 · 3 comments
Assignees
Labels
enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! triage_needed

Comments

@legrego
Copy link
Member

legrego commented Aug 26, 2021

When we detect a 401 response in an AJAX request, the security plugin assumes that the current user's session has timed out, and redirects the user back to the login page with a message indicating just that.

There are other reasons for a 401 response besides session timeouts. We should investigate a better mechanism for detecting actual session timeouts vs other reasons for 401 responses, and adjust the UX accordingly.

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! triage_needed enhancement New value added to drive a business result labels Aug 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jportner
Copy link
Contributor

jportner commented Sep 8, 2021

Current scenarios we can get unanticipated 401 errors:

We should detect specific situations where able, and otherwise show a different error message that doesn't imply the user's session timed out.

Note: split into separate issues Edit: done in #111551

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 10, 2021
@legrego
Copy link
Member Author

legrego commented Jan 25, 2022

We've addressed a majority of our 401 shortcomings recently:

The remaining items here focus on configuration mismatches across multiple Kibana instances. We have other issues tracking this broader work, so I'll close this in favor of those:

@legrego legrego closed this as completed Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! triage_needed
Projects
None yet
Development

No branches or pull requests

4 participants