Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation service] Expose level field to config deprecations #110603

Closed
Bamieh opened this issue Aug 31, 2021 · 1 comment · Fixed by #111516
Closed

[Deprecation service] Expose level field to config deprecations #110603

Bamieh opened this issue Aug 31, 2021 · 1 comment · Fixed by #111516
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0

Comments

@Bamieh
Copy link
Member

Bamieh commented Aug 31, 2021

We assumed that all config deprecations are of level critical hence we did not expose this field to the deprecation factory.

A few configs are indeed not critical for 8.0 hence allowing devs to override the level make sense here. Examples:

  1. Session timeout - starting in 8.0, the default timeout/lifespan will be 1h/30d (respectively). if a user does not have these values set, we advise them that they can be configured before the 8.0 release.
  2. deprecated usage of elasticsearch.username - this will not break in 8.0, we will break it in the future, so I’d like to keep the deprecation message but it is not critical as it will not prevent them from upgrading
  3. deprecated usage of legacy audit logs - again, this will not break in 8.0, but we will break it in the future

cc @jportner @alisonelizabeth

@Bamieh Bamieh added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 v7.16.0 labels Aug 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants