-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Correctly type kibana config #112146
Comments
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
So I was looking at how infra plugin handles config (cc @weltenwort to confirm that this is a reasonable plugin to copy from) and it's quite different. I suspect in order to get good typing of how monitoring plugin handles configs, we'll have to switch away from the Line 109 in 270adf4
|
I guess the other option might be to at least switch our I'll try that out and see if it's worth the gain compared with the larger refactoring away from |
I think kibana/x-pack/plugins/monitoring/server/plugin.ts Lines 331 to 332 in 4bcee04
I'll see what happens if I start swapping out |
Currently the config has a getter that we use and pass in the string of the property config name, but it's typed to always return a string or undefined which is not always the case.
The text was updated successfully, but these errors were encountered: