Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring][Angular removal] Stack monitoring sidenav link not working from inside monitoring #112431

Closed
Tracked by #115026
estermv opened this issue Sep 16, 2021 · 2 comments · Fixed by #114727
Closed
Tracked by #115026
Assignees
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@estermv
Copy link
Contributor

estermv commented Sep 16, 2021

Summary

While a user is inside Stack Monitoring and clicks on the Stack Monitoring link in the sidenav, the URL is changed but the page is not updated.

This happens because in React we had to create a new history object to keep the hash we have in the URLs but we need to make use of the history instance that Kibana platform provides in the AppMountParameters.

There are some plugins that also have hash in the urls and they seem to keep both instances of history with some mechanism to keep them in sync.

In the react application for Stack Monitoring, history is created here. It also overrides some methods from history to keep search params between routes.

There is also the GlobalState class, that keeps in sync the global state with the URL and QueryState from the data plugin. It also creates a history instance (it was there prior to the Angular migration) that passes to createKbnUrlStateStorage, so we might need to keep it in sync too.

NOTE: as the globalState class is used both in Angular and React it might be easier if this is solved after removing angular.

@estermv estermv added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring Epic: Stack Monitoring de-angularization labels Sep 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@matschaffer
Copy link
Contributor

This seems like a post-angular-removal issue to me. Links to other apps in the nav bar don't seem to break and it seems a little unlikely that a user would even try to re-click the side nav to get back to the top of stack monitoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants