Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]Rebranding required in the Import modal text #115537

Closed
Tracked by #116336
ghost opened this issue Oct 19, 2021 · 10 comments
Closed
Tracked by #116336

[Security Solution]Rebranding required in the Import modal text #115537

ghost opened this issue Oct 19, 2021 · 10 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.16.0

Comments

@ghost
Copy link

ghost commented Oct 19, 2021

Describe the bug
Rebranding required in the Import modal text

Build Details

Version: 7.16.0-SNAPSHOT
Commit:f002f58fd6cd35f8ecf97f5e64d1f836d96c51e5

Steps

  • Go to Rule page of Detect Group
  • click on Import button
  • Observe the text in the modal that is Select Security rules (as exported from the Detection Rules page) to import and in that old page name that is Detection Rule page 🔴 is mentioned , rebranded name of page should be there either Rule Page or Detect Rule Page

Actual
Old page names is mentioned in the Import Rule Modal Text

Expected
Rebranding required in the Import modal text

Screen-Shoot
image

  • Old Page naming
    image

logs

  • N/A
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@manishgupta-qasource
Copy link

Reviewed & assigned to @MadameSheema

@MadameSheema MadameSheema added Team:Detection Rule Management Security Detection Rule Management Team and removed triage_needed labels Oct 20, 2021
@MadameSheema
Copy link
Member

@jethr0null can you please take a look to this and help the team with a copy? Thanks :)

@rylnd
Copy link
Contributor

rylnd commented Oct 20, 2021

@jethr0null we're looking for copy to address both the outdated navigation reference here, and also potentially to make mention of the new actions import/export behavior exposed in #115243. I'll start with a suggestion:

Select rules and actions (as exported from the Security > Rules page) to import

@jethr0null
Copy link

Thanks @rylnd.

I do have a couple of questions. Does that copy reflect the steps that the team is adding to the documentation? Also, would the user need to import multiple files (one for rules and one for actions) based on the implementation we've chosen? If not, it might be confusing to call out actions explicitly in the copy.

@banderror banderror added the Feature:Rule Management Security Solution Detection Rule Management label Oct 21, 2021
@banderror banderror removed their assignment Oct 21, 2021
@bilelmeddeb
Copy link

hello @karanbirsingh-qasource . where did you find the 7.16.0 version ?

@ghost
Copy link
Author

ghost commented Oct 25, 2021

hello @karanbirsingh-qasource . where did you find the 7.16.0 version ?

Hi @bilelmeddeb I had reported this issue on 7.16.0-SNASHOT available on Elastic QA Cloud Platform. However same issue can be found on 7.16.0 BC1.

Build Details:

Version:7.16.0 BC1
Commit:9231d806c9384df4026977ba7435a9302dc2d4ab
Build:45504

image

@jethr0null
Copy link

For 7.16, let's go with the suggested copy and we can open a subsequent issue if we want to add information about actions and exceptions import once all of that functionality has been released.

Select rules and actions (as exported from the Security > Rules page) to import

@banderror
Copy link
Contributor

@karanbirsingh-qasource the issue has been addressed and backported to 7.16. Should be available in BC5. Thank you.

@ghost
Copy link
Author

ghost commented Nov 18, 2021

Hi @banderror thanks for the comment.

we have validated this issue on 7.16.0 BC5 and found it fixed ✔️

Build Details:

version: 7.16.0 BC5
Commit:f13296db8798dd0cd39ab6cc4a61a35a2a2b05cc
Build:46061

Snap Shoot:

image

Hence we are closing this issue.

thanks !!

c.c @MadameSheema

@ghost ghost closed this as completed Nov 18, 2021
@ghost ghost added the QA:Validated Issue has been validated by QA label Nov 18, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.16.0
Projects
None yet
Development

No branches or pull requests

9 participants