Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring plugin elasticsearch config deprecations #115597

Open
jportner opened this issue Oct 19, 2021 · 1 comment
Open

Monitoring plugin elasticsearch config deprecations #115597

jportner opened this issue Oct 19, 2021 · 1 comment
Labels
chore Team:Monitoring Stack Monitoring team

Comments

@jportner
Copy link
Contributor

jportner commented Oct 19, 2021

There are several config settings that are deprecated as of 7.16 and show up in the upgrade assistant:

These are not breaking in 8.0, but we want the deprecations to show in the Upgrade Assistant in 7.16 to encourage users to fix their configs. I updated these deprecation warnings for Core in #115241.

The Monitoring plugin inherits these "root" settings by default, or they can be set separately for Monitoring using the monitoring.ui. prefix.
Unfortunately, while working on the PR linked above, I discovered that any issue with the root settings would surface twice in the Upgrade Assistant -- once from Core, and once from the Monitoring plugin.

To ensure that the Upgrade Assistant experience in 7.16 isn't confusing, I removed these deprecations from the Monitoring plugin (see #115241 (comment)).

The deprecations should be added again in the Monitoring plugin, but they should only show up if the Monitoring plugin is not inheriting the root settings from Core.

// TODO: Add deprecations for "monitoring.ui.elasticsearch.username: elastic" and "monitoring.ui.elasticsearch.username: kibana".
// TODO: Add deprecations for using "monitoring.ui.elasticsearch.ssl.certificate" without "monitoring.ui.elasticsearch.ssl.key", and
// vice versa.
// ^ These deprecations should only be shown if they are explicitly configured for monitoring -- we should not show Monitoring
// deprecations for these settings if they are inherited from the Core elasticsearch settings.
// See the Core implementation: src/core/server/elasticsearch/elasticsearch_config.ts

This is not imperative for the 7.16 release, it can be done in the 8.x timeframe.

@jportner jportner added chore Team:Monitoring Stack Monitoring team labels Oct 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Monitoring Stack Monitoring team
Projects
None yet
Development

No branches or pull requests

2 participants