Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule cancellation support for metrics threshold and log threshold rule types #122550

Closed
Tracked by #123053
pmuellr opened this issue Jan 10, 2022 · 1 comment
Closed
Tracked by #123053
Labels
Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.4.0

Comments

@pmuellr
Copy link
Member

pmuellr commented Jan 10, 2022

The alerting system now supports cancellation, which is currently only driven via timeouts. A rule can check manually if it's been cancelled, while it's running, and can get "free" cancellation support via an instrumented ES client. The PR [Alerting] Using abortable es client in stack rules #122435 is doing this work for the stack alerts, and should be a good example to follow when adding cancellation support to a rule executor.

While we want ALL rules to be able to support cancellation in this way, I've created this specific issue for metrics threshold and log threshold rule types, as they've been the rule types that we've seen most frequently go over the rule timeout (5 minutes).

@simianhacker
Copy link
Member

@emma-raffenne emma-raffenne closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.4.0
Projects
None yet
Development

No branches or pull requests

3 participants