Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability rules view] two refresh buttons #128449

Closed
katrin-freihofner opened this issue Mar 24, 2022 · 5 comments · Fixed by #130526
Closed

[Observability rules view] two refresh buttons #128449

katrin-freihofner opened this issue Mar 24, 2022 · 5 comments · Fixed by #130526
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Project: Actionable Observability - DEPRECATED Deprecated - Do not use Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0

Comments

@katrin-freihofner
Copy link
Contributor

Kibana version:
running this PR: #128437 (review) locally

Describe the bug:
There are two refresh buttons, we only need one.
Screenshot 2022-03-24 at 08 08 32

Expected behavior:
We need to remove one of the refresh buttons. I don't think it matters too much which one for now. This is a screenshot from the Stack management rules view for reference:
Screenshot 2022-03-24 at 08 18 10

@katrin-freihofner katrin-freihofner added bug Fixes for quality problems that affect the customer experience Project: Actionable Observability - DEPRECATED Deprecated - Do not use Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Mar 24, 2022
@mgiota
Copy link
Contributor

mgiota commented Mar 24, 2022

@katrin-freihofner In the design screenshot here #119100 we have 2 buttons. Do we still consider it a bug?

@katrin-freihofner
Copy link
Contributor Author

@mgiota I'm sorry, this is a mistake in the design. I would recommend removing the second refresh button (the small one with the icon)

@emma-raffenne
Copy link
Contributor

emma-raffenne commented Apr 5, 2022

@katrin-freihofner
Those buttons have different behaviour. The smaller button allows to set an automatic refresh period (see screenshot below), while the bigger one at the top right is to force immediate refresh.
Do you confirm that we still want to remove the smaller one with automatic refresh?

rules-view-refresh-button1

@mgiota FYI

@katrin-freihofner
Copy link
Contributor Author

Yes, I still think that we don't need the refresh every X seconds functionality for the rules view.

@simianhacker
Copy link
Member

When we remove the auto-refresh, we should also close this issue: #128868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project: Actionable Observability - DEPRECATED Deprecated - Do not use Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants