Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Refactor drag and drop #128506

Closed
mbondyra opened this issue Mar 24, 2022 · 2 comments
Closed

[Lens] Refactor drag and drop #128506

mbondyra opened this issue Mar 24, 2022 · 2 comments
Assignees
@mbondyra
Labels
Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

Describe the feature:
Features that we'd like to include:

  • make the getDropProps not completely execute in datasource (most of the information is known outside of datasource and doesn't depend on it)
  • add a custom onDrop hook for visualization in case if datasource doesn't exist for visualization
  • [optional] allow dropping between layers
@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mbondyra mbondyra mentioned this issue Mar 24, 2022
Merged
@mbondyra mbondyra self-assigned this Mar 24, 2022
@mbondyra mbondyra mentioned this issue Mar 24, 2022
Closed
@mbondyra mbondyra changed the title [Lens] refactor drag and drop [Lens] Refactor drag and drop Apr 4, 2022
@mbondyra mbondyra mentioned this issue Apr 4, 2022
Closed
@mbondyra
Copy link
Contributor Author

mbondyra commented May 4, 2022

Closing in favor of #90441

@mbondyra mbondyra closed this as completed May 4, 2022
@exalate-issue-sync exalate-issue-sync bot reopened this May 4, 2022
@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbondyra @elasticmachine