Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chrome UI] Change in scrollbar behavior shifts UI #129764

Open
jamiesmith opened this issue Apr 7, 2022 · 9 comments
Open

[Chrome UI] Change in scrollbar behavior shifts UI #129764

jamiesmith opened this issue Apr 7, 2022 · 9 comments
Labels
bug Fixes for quality problems that affect the customer experience old Used to help sort old issues on GH Projects which don't support the Created search term. Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@jamiesmith
Copy link
Contributor

There was a change in the overall scrollbar behavior in Kibana, some time after 7.14.

In 7.x up to 7.14 the scrollbar disappeared when not scrolling which left a clean UI, but with more recent versions it is basically hardcoded on, and done so in such a way that the UI is different when there's a scrollbar. It's kind of jarring when using the interface, especially when trying to make tutorials or even just basic screenshots.

I'd love for it to go back to the way it was, but at the very least can it be made to not shift the entire UI? Screenshots below.

Kibana version:
I think that this problem was introduced in 7.15 or 7.16

Elasticsearch version:
Any

Server OS version:
Any

Browser version:
Chrome, safari, or Firefox

Browser OS version:
Windows or Mac

Original install method (e.g. download page, yum, from source, etc.):
Multiple methods

Describe the bug:
When the scrollbar is present the entire UI shifts

Steps to reproduce:
(note that these links are only accessible for elastic employees, instead see the screenshots below)

  1. See that the dashboard from a 7.14 install exhibits the desired behavior
  2. Compare it to this log stream page which has a scrollbar and this infra waffle map which shouldn't

Expected behavior:
The scrollbar should only show up when scrolling and not completely change the UI when it's present
Screenshots (if relevant):

This is what it looks like now - the whole banner shifts:
scrollbar-8 1

This is what it looked like in <= 7.14 - notice that, when scrolling, it's just a subtle overlay without impacting the entire layout
scrollbar-7 14

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@jamiesmith jamiesmith added the bug Fixes for quality problems that affect the customer experience label Apr 7, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 7, 2022
@alexfrancoeur
Copy link

@cchaos @clintandrewhall this seems to be a constant pain for marketing when it comes to recording and screenshots. Would the shared ux team own this type of issue? Or is it a level deeper like EUI?

@cchaos
Copy link
Contributor

cchaos commented Apr 7, 2022

I'm pretty sure this is an operating system / browser option.

Screen Shot 2022-04-07 at 12 27 39 PM

EUI (nor Kibana) does anything to change the default body scrollbar. EUI provides a mixin to style the smaller internal scrollbars you see on those panels but they don't hide/show.

@jamiesmith
Copy link
Contributor Author

No, something definitely changed. The GIFs above were taken on the same computer, today

@jamiesmith
Copy link
Contributor Author

Granted the change was months ago

@cchaos
Copy link
Contributor

cchaos commented Apr 7, 2022

I think I'm tracking better what you're indicating, which is that Kibana is no longer respecting the Show scroll bars: When scrolling option. It's not that the scrollbars only show on scroll, causing the layout to shift, but that they only show up when scrolling is needed.

There was an EUI update almost a year ago that changed the color of the body scrollbars based on dark/light mode. elastic/eui#4969

The presence of these styles may indicate to the browser to not use the overlay style of scrollbar. Without doing any research into why this happens, I see 3 possible courses of action:

  1. Nothing. Prefer matching color modes.
  2. Find a way to only apply the custom scroll styles in dark mode (but this issue would still exist in dark mode)
  3. Revert the style change, preferring this interaction, thus undoing the fix for dark mode.

But none of those options would still fix the issue for users (like me) who keep the system option Show scroll bars: Automatically / Always. This is just how browser's interpret when to show / not show scrollbars. The only other option would be to force them to always show on the body with overflow: scroll, but I don't think anyone wants that.

@jamiesmith
Copy link
Contributor Author

Yeah, it was more than just a change in the color, it's the overall behavior. If you want me to show in more detail what I mean I'd be happy to jump on a zoom.

Your comment of "overlay" is exactly what seems to be missing

@clintandrewhall
Copy link
Contributor

@cchaos can we pad the right-hand dynamically to prevent the content shift? I haven't played with this in a while, but I seem to recall being able to do that... we did it Canvas somehow, (@cqliu1, @crob611)

@cchaos
Copy link
Contributor

cchaos commented Apr 11, 2022

You'll not want to add padding-right to the html or body element when scroll isn't available because it would make for an awkward blank space on the right hand side of all pages. If you do that, you might as well set scroll-y: scroll which shows the scrollbars always. This still isn't ideal as it still creates awkward empty space to the right of each page.

This honestly isn't an easy question to answer. Mainly because we're still talking about very specific OS settings and user preference vs how browser's inherently deal with overflow scrolling.

@rayafratkina rayafratkina added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels May 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label May 31, 2022
@vadimkibana vadimkibana changed the title Change in scrollbar behavior shifts UI [Chrome UI] Change in scrollbar behavior shifts UI Aug 14, 2023
@vadimkibana vadimkibana self-assigned this Sep 14, 2023
@vadimkibana vadimkibana removed their assignment Nov 9, 2023
@petrklapka
Copy link
Member

This behavior is currently by design, with no intention to change.

@petrklapka petrklapka added the old Used to help sort old issues on GH Projects which don't support the Created search term. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience old Used to help sort old issues on GH Projects which don't support the Created search term. Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

7 participants