Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Allow reference line text to be rotated in visualizations #133073

Open
Tracked by #175869 ...
A-Hall opened this issue May 27, 2022 · 4 comments
Open
Tracked by #175869 ...

[Lens] Allow reference line text to be rotated in visualizations #133073

A-Hall opened this issue May 27, 2022 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@A-Hall
Copy link
Member

A-Hall commented May 27, 2022

Describe the feature:

In some situations, the text in reference lines can overlap causing them to be hard or impossible to read. Allowing users to rotate the text 90º would allow for the text to be readable in situations like this.

1111

rotate

@A-Hall A-Hall added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label May 27, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label May 27, 2022
@stratoula stratoula added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels May 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 30, 2022
@ghudgins ghudgins changed the title Allow reference line text to be rotated in visualizations [Lens] Allow reference line text to be rotated in visualizations May 31, 2022
@markov00
Copy link
Member

@flash1293 the label can already be "rotated" ( you are actually rotating the label by 90 degree, but the standard behaviour is to have text labels horizontally laid).
For example you can achieve the following by using the marker code below:

Screenshot 2022-08-17 at 12 37 04

marker={
          <div
            style={{
              position: 'absolute',
              right: 0,
              bottom: 1,
              background: 'rgba(255, 255, 255, 0.5)',
              whiteSpace: 'nowrap',
              textAlign: 'right',
            }}
          >
            horizontal text
          </div>
        }
        markerPosition={Position.Right}

@flash1293
Copy link
Contributor

@markov00 Right, the input required from datavis is more about whether this is the right approach or not. @gvnmagni spent some time thinking about the general issue and how to handle it. Do you have any guidance here, Gio?

@gvnmagni
Copy link

I have to admit that I don't have a proper guidance here but I can spend some time trying to see if there is a good solution. My main worries are related to the scalability of the rotated labels (even with just few reference lines we would risk overlapping) and to the amount of space needed to make this to work outside of chart right side limit (causing this chart to be no aligned to other charts in a dashboard). Let me think about this a little and let me see if there is a way to make this work

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jan 10, 2023
@stratoula stratoula added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

7 participants