Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet]: Incorrect agents count under Upgrade modal and confirmation pop-up when upgraded from bulk actions. #134329

Closed
amolnater-qasource opened this issue Jun 14, 2022 · 12 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana version: 8.3 Snapshot Kibana cloud environment

Host OS and Browser version: All, All

Build details:

VERSION: 8.3.0
BUILD: 53383
COMMIT: 492b369bcdccc92d804e0fbc1a2642ac5afb46a9

Preconditions:

  1. 8.3 Snapshot Kibana cloud environment should be available.
  2. 25 lower 8.2.0 agents should be installed.

Steps to reproduce:

  1. Login to Kibana environment.
  2. Navigate to fleet select 20 agents and click Upgrade agent from bulk actions.
  3. Select Maintenance window time to 1 hour.
  4. Click upgrade and observe 19 agents count under Upgrade modal.
  5. Observe 20 agents count under confirmation pop-up.

Expected Result:
Correct agents count should be displayed under Upgrade modal and confirmation pop-up when upgraded from bulk actions.

Screenshot:

15

@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Jun 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@jen-huang
Copy link
Contributor

@nchaulet @criamico Lower priority bug but wondering if you had any guess as to why the count might be off?

@nchaulet
Copy link
Member

The toast show the number of agents currently upgrading, that number is going to change over time, I think in the screenshot you probably already have one agent that completed the upgrade.

@jen-huang
Copy link
Contributor

@amolnater-qasource Would it be possible to check Nicolas's hypothesis?

@amolnater-qasource
Copy link
Author

Hi Team
Thanks for the feedback @nchaulet we have revalidated this issue on latest 8.3 Snapshot and found it still reproducible.

  • Incorrect agents count under Upgrade modal and confirmation pop-up when upgraded from bulk actions.

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-06-16.16-09-19.mp4

Build details:
BUILD: 53413
COMMIT: 875ea18

cc: @jen-huang
Please let us know if anything else is required from our end.
Thanks

@jen-huang
Copy link
Contributor

@amolnater-qasource What I mean is, 20 agents may have indeed been triggered for upgrade, but 1 agent could have already finished upgrading before the blue callout is shown, therefore making it show 19 "remaining" to upgrade. Would it be possible for you to take a list of the 20 agents that you have triggered upgrade on, and see if one of them indeed finished very quickly?

@nchaulet
Copy link
Member

@amolnater-qasource What I mean is, 20 agents may have indeed been triggered for upgrade, but 1 agent could have already finished upgrading before the blue callout is shown, therefore making it show 19 "remaining" to upgrade. Would it be possible for you to take a list of the 20 agents that you have triggered upgrade on, and see if one of them indeed finished very quickly?

I see you are using it's possible that the upgrade is almost instant here because it's not a real agent

@amolnater-qasource
Copy link
Author

Hi @jen-huang

Would it be possible for you to take a list of the 20 agents that you have triggered upgrade on, and see if one of them indeed finished very quickly?

Currently we are using horde agents to test this and they get stuck in updating state even after upgrade. So it won't be possible to track which agent has upgraded successfully. Further with actual agents also we have a running issue of upgrade failure reported at elastic/elastic-agent#526

I see you are using it's possible that the upgrade is almost instant here because it's not a real agent

Yes @nchaulet, we agree to this It could be possible that the agent upgrade is so instant that its not getting tracked under blue upgrade callout.

Please do let us know if we can test it in any other way or we can close this issue for now and track it in later builds.

Thanks

@jen-huang
Copy link
Contributor

The only other thing I can think of is using a few real agents, whose upgrades will not be instant, and checking the count. Going to close this for now but feel free to re-open if it is an issue with real agents.

@jen-huang jen-huang closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2022
@amolnater-qasource
Copy link
Author

Hi Team
We have revalidated upgrading real 8.2.3 agent to 8.3.0 Kibana cloud production environment and had below observations:

  • Correct agents count is displayed under Upgrade modal and confirmation pop-up when upgraded from bulk actions.

Build details:
BUILD: 53518
COMMIT: 8a54c80
Artifact Link: https://www.elastic.co/downloads/past-releases/elastic-agent-8-2-3

Integrations:
System & Endpoint Security

Screenshots:
11

Hence marking this as QA:Validated.
Thanks

@amolnater-qasource amolnater-qasource added the QA:Validated Issue has been validated by QA label Jun 29, 2022
@jen-huang
Copy link
Contributor

Thanks Amol!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

5 participants