Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controls] Refactor Range Slider Popover #137888

Closed
ThomThomson opened this issue Aug 2, 2022 · 1 comment · Fixed by #138037
Closed

[Controls] Refactor Range Slider Popover #137888

ThomThomson opened this issue Aug 2, 2022 · 1 comment · Fixed by #138037
Assignees
@cqliu1
Labels
enhancement New value added to drive a business result Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Problem
After #136572, made embeddable state management for Controls easier, it became clear that some of the components in the Range Slider could use a bit of refactoring. Specifically the range_slider.component.tsx, was previously just a wrapper to pass down some props. Now that component state can be accessed from anywhere in the react tree this is no longer necessary.

Additionally, there should be some level of separation, component-wise between the popover and the component for DX / organization's sake.
@ThomThomson ThomThomson added Feature:Input Control Input controls visualization enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson mentioned this issue Aug 2, 2022
Merged
1 task
@cqliu1 cqliu1 self-assigned this Aug 2, 2022
@cqliu1 cqliu1 mentioned this issue Aug 3, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqliu1 cqliu1

Labels
enhancement New value added to drive a business result Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Controls] Refactors range slider control cqliu1/kibana
3 participants
@cqliu1 @ThomThomson @elasticmachine