Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Replace global styles with emotion syntax for Alerts Page #138526

Closed
jasonrhodes opened this issue Aug 10, 2022 · 2 comments
Closed

[Observability] Replace global styles with emotion syntax for Alerts Page #138526

jasonrhodes opened this issue Aug 10, 2022 · 2 comments
Assignees
@CoenWarmer
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@jasonrhodes
Copy link
Member

This PR added a hand-rolled, custom className to some elements on the alerts page in the observability plugin so that the styles in this SCSS file would no longer be global to Kibana.

We should remove that scss file and replace it with emotion CSS syntax (as recommended by the @elastic/eui-design team).
@jasonrhodes jasonrhodes added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Aug 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@CoenWarmer CoenWarmer self-assigned this Mar 6, 2023
@CoenWarmer
Copy link
Contributor

Fixed with #152888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoenWarmer CoenWarmer

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jasonrhodes @CoenWarmer @kdelemme @elasticmachine