Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Remove 7 to 8 deprecated Core API's #142915

Open
TinaHeiligers opened this issue Oct 6, 2022 · 7 comments
Open

[meta] Remove 7 to 8 deprecated Core API's #142915

TinaHeiligers opened this issue Oct 6, 2022 · 7 comments
Assignees
Labels
chore deprecation_warnings Epic:Deprecations Deprecations Meta Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

Deprecated Core API's that need to be removed:

target version domain package priority
8.8 application-browser TBD
8.8 application-browser mocks TBD
8.8 core-apps-browser-internal TBD
8.8 core-elasticsearch-server-internal TBD
8.8 core-http-browser-internal TBD
8.8 core-metrics-server-internal TBD
8.8 core-saved-objects-migration-server-internal TBD
8.8 core-saved-objects-server-internal TBD
8.8 core-status-server-internal TBD
8.8 core-usage-data-server-internal TBD
@TinaHeiligers TinaHeiligers added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc deprecation_warnings labels Oct 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@lukeelmers lukeelmers added the Meta label Oct 6, 2022
@pgayvallet
Copy link
Contributor

pgayvallet commented Oct 11, 2022

Some comments:

  • @kbn/application-browser

This is about onAppLeave and AppLeaveHandler. AFAIK this can't be removed until we find a proper replacement (see #132600)

  • @kbn/core-apps-browser-internal
  • @kbn/core-status-server-internal
  • @kbn/core-metrics-server-internal
  • @kbn/core-usage-data-server-internal

It's about process on the Ops stats (OpsMetrics.process). This is surfacing to public APIs via the stats endpoints, so can we really remove this? Not sure who followed this point, @lukeelmers maybe?

  • @kbn/core-elasticsearch-server-internal

It's about the legacy config exposure. We don't have a replacement for that yet (see #119862)

  • core-http-browser-internal

This is about the req and res shorthands on IHttpFetchError. Should use request and response instead. Depending on how many consumers are using these properties, it should be fairly easy to remove.

  • @kbn/core-saved-objects-migration-server-internal

it's about SavedObjectsMigrationLogger.warning, deprecated in favor of .warn. Removal should be low risk and usages easily identified by the typescript checker, likely.

  • @kbn/core-saved-objects-server-internal

It's about SavedObjectAttributes that is deprecated in favor of just not using it. @rudolf any idea of the effort to remove the remaining usages in the code base?

@rudolf
Copy link
Contributor

rudolf commented Oct 11, 2022

It's about SavedObjectAttributes that is deprecated in favor of just not using it. @rudolf any idea of the effort to remove the remaining usages in the code base?

I suspect it should be fairly easy for someone who knows the plugins (e.g. the owners) to remove this type. I don't think Core can do this, because often SavedObjectAttributes hides the fact that there isn't an existing type that actually fully describe the saved object type and for us to come up with such a type could be difficult.

@TinaHeiligers
Copy link
Contributor Author

Additional deprecations for which we do not have a definitive action yet:

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Dec 17, 2022

#147723 implements the following changes:

target version domain package notes
-- application-browser blocked by #132600: Deprecation replaced with remarks
-- application-browser mocks blocked by #132600: Deprecation replaced with remarks
-- core-apps-browser-internal process on the Ops stats (OpsMetrics.process) surfacing to public APIs via the stats endpoints, cannot remove: replaced deprecation with remarks
-- core-status-server-internal process on the Ops stats (OpsMetrics.process) surfacing to public APIs via the stats endpoints, cannot remove: replaced deprecation with remarks
-- core-metrics-server-internal process on the Ops stats (OpsMetrics.process) surfacing to public APIs via the stats endpoints, cannot remove: replaced deprecation with remarks
-- core-usage-data-server-internal process on the Ops stats (OpsMetrics.process) surfacing to public APIs via the stats endpoints, cannot remove: replaced deprecation with remarks
-- core-elasticsearch-server-internal blocked by #119862. no remove-by version target, leaving as is
removed core-saved-objects-migration-server-internal removed deprecated logger.warning & migrated log level to warn where needed
-- core-saved-objects-server-internal Core cannot remove the type. Removal dependent on consumer type-safety requirements

Still todo:
core-http-browser-internal

@TinaHeiligers
Copy link
Contributor Author

Penciling in myself to see this issue through, pending availability

@TinaHeiligers TinaHeiligers changed the title [meta] Remove deprecated Core API's [meta] Remove 7 to 8 deprecated Core API's Apr 2, 2024
@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Apr 2, 2024

refers to new meta issue for 8 to 9 deprecations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore deprecation_warnings Epic:Deprecations Deprecations Meta Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

5 participants