Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataViews] Create data view flyout duplicate name validation fails for auto-generated names #146338

Closed
davismcphee opened this issue Nov 25, 2022 · 3 comments
Closed

[DataViews] Create data view flyout duplicate name validation fails for auto-generated names #146338

davismcphee opened this issue Nov 25, 2022 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@davismcphee
Copy link
Contributor

The create data view flyout duplicate name validation doesn't work when the data view name is auto generated from an index pattern. Instead the request just fails and displays a toast when the save button is clicked. The same validation logic used when a duplicate name is manually entered (#146126) should be used here as well:
image
@davismcphee davismcphee added bug Fixes for quality problems that affect the customer experience loe:small Small Level of Effort Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) :DataDiscovery/fix-it-week labels Nov 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee changed the title Create data view flyout duplicate name validation fails for auto-generated names [DataViews] Create data view flyout duplicate name validation fails for auto-generated names Nov 25, 2022
@mattkime
Copy link
Contributor

I'll address this after #143604 is merged

@mattkime
Copy link
Contributor

This was fixed by #143604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattkime @elasticmachine @davismcphee