Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ability to reset panel state/embeddable config #15665

Closed
stacey-gammon opened this issue Dec 18, 2017 · 1 comment
Closed

Expose ability to reset panel state/embeddable config #15665

stacey-gammon opened this issue Dec 18, 2017 · 1 comment
Labels
Feature:Dashboard Dashboard related features release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@stacey-gammon
Copy link
Contributor

stacey-gammon commented Dec 18, 2017

There are certain actions a user can make with an embeddable that will cause it's state to be overridden and saved with a dashboard. After this happens, there is no way* to reset that overridden state so your embeddable is once again synced with the underlying saved object.

*there are some work arounds - either to edit the dashboard state in saved object management, or remove the panel from the dashboard and re-add it.

For instance:

  • Once you change colors on a visualization in a dashboard panel, you won't get any new color updates for that value
  • Once you sort on a saved search in a dashboard panel you will stop getting any sort updates saved with the original saved search.
  • Once you add, move or remove columns on a saved search in a dashboard panel you will stop getting any column updates saved with the original saved search.

I think for now those are the only three situations we have, but there could be more. Essentially, we want to expose a way to reset all the state inside embeddableConfig so the embeddable goes back to it's original form, outside of the dashboard panel.

We may also want to expose what exactly is saved in that configuration and allow it to be manually tweaked, but it'd be in the form of JSON, so might not be very user friendly. If we wanted to expose a more user friendly description of what was saved, we'd need to have each embeddable expose it so dashboard can continue to not care what is inside the embeddable config.

We already kind of expose this functionality with reset title on panel customization, so maybe something in that menu. Here is a horribly hacky throw together of where abouts it could go:
screen shot 2017-12-18 at 10 18 53 am but tagging design team as they may have better ideas.

Perhaps as a step one we just expose a Reset config option and worry about exposing the details of what is inside the configuration as a second step. Wording could probably use some improvement too.

This was briefly discussed as part of #9523 but I'm now pulling this specific feature request into it's own issue.

cc @elastic/kibana-sharing @elastic/kibana-visualizations @elastic/kibana-design

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing labels Sep 14, 2018
@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@ThomThomson
Copy link
Contributor

Closing this in favor of #132457.

It is currently possible to reset panel states, but the user needs to enter and exit edit mode. With the above issue it will be a one-click action from view mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants