Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Add "and XXX more fields" to the rows in a table like in ES|QL mode #169378

Closed
ninoslavmiskovic opened this issue Oct 19, 2023 · 7 comments
Labels
enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@ninoslavmiskovic
Copy link
Contributor

ninoslavmiskovic commented Oct 19, 2023

When the setting for the row is set to "Auto" then show the same amount of fields as in ES|QL mode and add "and XXX more fields". This will give a better experience for the user, than the current limit on fields in Discover, when in "Auto" mode, which is around 200 fields.

Example:

Skaermoptagelse.2023-10-19.kl.14.41.42.mov
@ninoslavmiskovic ninoslavmiskovic added enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Oct 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta
Copy link
Contributor

Discover already has this logic. And user can configure the number of visible fields via discover:maxDocFieldsDisplayed. Or do you mean something else?

@ninoslavmiskovic
Copy link
Contributor Author

I mean doing it as default like ES|QL mode. We have "auto" on by default, but we are showing around 200 fields, and not truncating and adding the sentence "xxx more fields"

@jughosta
Copy link
Contributor

ES|QL adopted the truncation logic which exists in Discover. For your example it does not show "and XXX more fields" because there are less than 200 fields with data anyway. Try reducing discover:maxDocFieldsDisplayed setting to 5 for example to see the effect on Discover page.

@ninoslavmiskovic
Copy link
Contributor Author

Got it , so maybe the request should be rephrased to shorten the default amount of fields, so it's not 200.

@kertal
Copy link
Member

kertal commented Oct 23, 2023

What number would you prefer to be default?

@kertal
Copy link
Member

kertal commented Oct 25, 2023

I'm closing this, because we discussed and the way it works is like expected. setting the value discover:maxDocFieldsDisplayed won't provide much help. What we currently are evaluating is reverting #164218, so the default is no longer to auto fit the row

@kertal kertal closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Development

No branches or pull requests

4 participants