Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User profile] Add support for system theme #173895

Closed
pgayvallet opened this issue Dec 22, 2023 · 5 comments
Closed

[User profile] Add support for system theme #173895

pgayvallet opened this issue Dec 22, 2023 · 5 comments
Labels
Feature:Security/User Profile Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@pgayvallet
Copy link
Contributor

#89340 is a feature request to have a way for Kibana to select its theme based on the system's preference (system theme)

#173044 implements it by introducing a third option for the theme:darkMode uiSetting, and adding all the implementation details for this new option to be properly used.

However, this PR only adds the feature at the uiSettings level, introducing a feature gap between the two systems (uiSettings/advanced settings vs user profile).

This issue is here to address this feature gap, by adding support for this system theme option to the user profile.

From my understanding, given that #173044 already implements all the internal implementation of the theme switch / system theme detection, it should be rather straightforward (only adapting the user profile UI and the user settings service that was introduced in #151507), but I'd like the security team to confirm that point.

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/User Profile labels Dec 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego
Copy link
Member

legrego commented Feb 12, 2024

Awaiting #173044

@pgayvallet
Copy link
Contributor Author

FYI, #173044 has been merged 🎉

@legrego
Copy link
Member

legrego commented Jul 29, 2024

Closing as duplicate of #155945

@legrego legrego closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Security/User Profile Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

3 participants