Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Research] key sorting research spike #174949

Open
ThomThomson opened this issue Jan 16, 2024 · 3 comments
Open

[Research] key sorting research spike #174949

ThomThomson opened this issue Jan 16, 2024 · 3 comments
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort research Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Required for #167537.

We should look into Javascript object key sorting to determine how feasible it is to make a deterministic saved object for easy diffing.

We also need to see how it interacts with #167824 to determine if it's more difficult or less difficult to ensure proper key ordering after migration away from stringified JSON bags.

There is a package which allows for completely deterministic JSON stringification.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. research labels Jan 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl
Copy link
Member

FWIW, it appears there is some prior work on traversing and sorting objects when exporting saved objects.

@ThomThomson
Copy link
Contributor Author

Oh good find Nick! That might make this substantially easier. Especially if we were able to sort all keys as part of the export process itself. Then the javascript key order wouldn't matter so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort research Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants